Reorganize Catalog based on Catalog Organization Proposal #389

PuneetPunamiya · 2020-06-24T10:41:24Z

Changes

NOTE: This patch covers the first part of the issue where it modifies all the tasks and moves the tasks which don't need to be split to the task directory. The task which has to be split and moved to the task directory will be added in the next pr (Split tasks based on Catalog Organization Proposal #401) to make review easier

Each resource follows the following structure

    ./task/         👈 the kind of the resource 
      /argocd       👈 definition file must have same name
        /OWNERS     👈 owners of this ressource
        /README.md  👈 fallback README if version is missing README
        /0.1
          /README.md     👈 [optional] since there can be a fallback
          /argocd.yaml   👈 the file name must be resource name
          /samples/deploy-to-k8s.yaml
        /0.2/...
      /golang-build
        /0.1
          /README.md
          /golang-build.yaml
          /samples/golang-build.yaml

Resource YAML file includes following changes

Labels include the version of the resource.
Annotations include minimum pipeline version supported by the resource,
tags associated with the resource and displayName of the resource

  
labels:
  app.kubernetes.io/version: "0.1"            👈 version of the resource
  
annotations:
  tekton.dev/pipelines.minVersion: "0.12.1"   👈 will work from x version  of pipeline
  tekton.dev/tags: "ansible, cli"                        👈 Comma separated list of tags 
  tekton.dev/displayName: "Ansible Tower Cli"    
  
spec:
description: |-
  ansible-tower-cli task simplifies 
  workflow, jobs, manage users...   👈 # Summary
  
  Ansible Tower (formerly ‘AWX’) is a ...

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes docs (if user facing)
Commit messages follow commit message best practices
Yaml file complies with yamllint rules.

See the contribution guide
for more details.

task/makisu/0.1/makisu.yaml

makisu/makisu.yaml

sthaha · 2020-06-26T00:27:33Z

Please note Hub has been deployed to https://ui-tekton-hub.apps.openshift-web.p0s5.p1.openshiftapps.com/ based on this PR. I will force a resync of Hub tasks as more tasks are added to this PR.

vdemeester · 2020-06-30T10:13:19Z

/retest

github/set_status.yaml

github/close_issue.yaml

gcs/gcs-upload.yaml

PuneetPunamiya · 2020-07-06T17:26:15Z

/retest

gcs/gcs-create-bucket.yaml

gcs/gcs-delete-bucket.yaml

task/replace-tokens/0.1/replace-tokens.yaml

gcs/gcs-generic.yaml

gcs/gcs-upload.yaml

git/git-batch-merge.yaml

git/git-cli.yaml

task/skopeo-copy/0.1/skopeo-copy.yaml

task/upload-pypi/0.1/README.md

task/ibmcloud/0.1/README.md

…g proposal **NOTE: This only modifies the content of the yaml, changing the location of the file will be done in a different commit to make review easier Changes include: - adds version label - adds a minimum pipeline versions supported by the task - adds tags for task - adds display name for task - modified description to add a summary Issue: #386 Signed-off-by: Shiv Verma <[email protected]>

…roposal **NOTE: This only modifies the content of the yaml, changing the location of the file will be done in a different commit to make review easier Changes include: - adds version label - adds a minimum pipeline versions supported by the task - adds tags for task - adds display name for task - modified description to add a summary Issue: #386 Signed-off-by: Puneet Punamiya <[email protected]>

according to the new reorg proposal **NOTE: This only modifies the content of the yaml, changing the location of the file will be done in a different commit to make review easier Changes include: - adds version label - adds a minimum pipeline versions supported by the task - adds tags for task - modified description to add a summary Issue: #386 Signed-off-by: Puneet Punamiya <[email protected]>

bobcatfish · 2020-07-10T21:02:02Z

/lgtm
/approve

tekton-robot · 2020-07-10T21:02:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [bobcatfish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bobcatfish · 2020-07-23T21:40:31Z

Hey @PuneetPunamiya I'm surprised to see the OWNERS file in the versioned directories, can we move them one level up?

I'm guessing we'll have folks owning a Task across all versions, probably not a different set for each version (tho folks could add that if they wanted to)

sthaha · 2020-07-24T06:38:33Z

@bobcatfish Good catch! We completely missed it!

sthaha · 2020-07-24T06:46:51Z

@PuneetPunamiya @bobcatfish Hopefully this fixes it - #443

bobcatfish · 2020-07-24T17:16:09Z

np @sthaha - i missed it too!! I only noticed it when I was adding my own OWNERS file :D

tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2020

tekton-robot requested review from akihikokuroda and ncskier June 24, 2020 10:41

tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 24, 2020

sthaha suggested changes Jun 25, 2020

View reviewed changes

task/makisu/0.1/makisu.yaml Outdated Show resolved Hide resolved

makisu/makisu.yaml Outdated Show resolved Hide resolved

tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 25, 2020

sthaha mentioned this pull request Jun 25, 2020

Hub: fix api deployment tektoncd/experimental#570

Merged

1 task

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 30, 2020

tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 30, 2020

sthaha reviewed Jul 2, 2020

View reviewed changes

github/set_status.yaml Outdated Show resolved Hide resolved

sthaha reviewed Jul 2, 2020

View reviewed changes

github/close_issue.yaml Outdated Show resolved Hide resolved

sthaha reviewed Jul 2, 2020

View reviewed changes

gcs/gcs-upload.yaml Outdated Show resolved Hide resolved

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2020

sthaha reviewed Jul 7, 2020

View reviewed changes

gcs/gcs-create-bucket.yaml Outdated Show resolved Hide resolved

sthaha reviewed Jul 7, 2020

View reviewed changes

gcs/gcs-create-bucket.yaml Outdated Show resolved Hide resolved

sthaha reviewed Jul 7, 2020

View reviewed changes

gcs/gcs-delete-bucket.yaml Outdated Show resolved Hide resolved

pratap0007 reviewed Jul 7, 2020

View reviewed changes

task/replace-tokens/0.1/replace-tokens.yaml Outdated Show resolved Hide resolved

sthaha suggested changes Jul 7, 2020

View reviewed changes

gcs/gcs-generic.yaml Outdated Show resolved Hide resolved

gcs/gcs-upload.yaml Outdated Show resolved Hide resolved

git/git-batch-merge.yaml Outdated Show resolved Hide resolved

git/git-cli.yaml Outdated Show resolved Hide resolved

pratap0007 reviewed Jul 7, 2020

View reviewed changes

task/skopeo-copy/0.1/skopeo-copy.yaml Outdated Show resolved Hide resolved

pratap0007 reviewed Jul 7, 2020

View reviewed changes

task/upload-pypi/0.1/README.md Show resolved Hide resolved

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2020

pratap0007 reviewed Jul 7, 2020

View reviewed changes

task/ibmcloud/0.1/README.md Outdated Show resolved Hide resolved

pratap0007 and others added 4 commits July 10, 2020 14:55

tekton-robot assigned bobcatfish Jul 10, 2020

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2020

tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 10, 2020

tekton-robot merged commit 436f1e8 into tektoncd:master Jul 10, 2020

bobcatfish mentioned this pull request Jul 10, 2020

Allow Tasks/Pipelines to indicate versions of Tekton Pipelines they work with tektoncd/pipeline#2588

Closed

sthaha mentioned this pull request Jul 13, 2020

add triggers tasks #243

Closed

3 tasks

bobcatfish mentioned this pull request Jul 13, 2020

Add Tasks to acquire and release boskos resources 🐑 #408

Merged

2 tasks

This was referenced Jul 13, 2020

Create Docker Build task with sidecar in catalog #409

Merged

Add generic kubectl with path task #394

Closed

Add AWS ECR Login task #399

Merged

sthaha mentioned this pull request Jul 24, 2020

Make owners own all versions of a resource #442

Closed

PuneetPunamiya mentioned this pull request Jul 27, 2020

Prometheus gate #440

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reorganize Catalog based on Catalog Organization Proposal #389

Reorganize Catalog based on Catalog Organization Proposal #389

PuneetPunamiya commented Jun 24, 2020 •

edited

Loading

sthaha commented Jun 26, 2020

vdemeester commented Jun 30, 2020

PuneetPunamiya commented Jul 6, 2020

bobcatfish commented Jul 10, 2020

tekton-robot commented Jul 10, 2020

bobcatfish commented Jul 23, 2020

sthaha commented Jul 24, 2020

sthaha commented Jul 24, 2020

bobcatfish commented Jul 24, 2020

Reorganize Catalog based on Catalog Organization Proposal #389

Reorganize Catalog based on Catalog Organization Proposal #389

Conversation

PuneetPunamiya commented Jun 24, 2020 • edited Loading

Changes

Submitter Checklist

sthaha commented Jun 26, 2020

vdemeester commented Jun 30, 2020

PuneetPunamiya commented Jul 6, 2020

bobcatfish commented Jul 10, 2020

tekton-robot commented Jul 10, 2020

bobcatfish commented Jul 23, 2020

sthaha commented Jul 24, 2020

sthaha commented Jul 24, 2020

bobcatfish commented Jul 24, 2020

PuneetPunamiya commented Jun 24, 2020 •

edited

Loading