Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually bump tektoncd/pipelines dependency to v0.45 #711

Closed
chitrangpatel opened this issue Feb 17, 2023 · 8 comments
Closed

Manually bump tektoncd/pipelines dependency to v0.45 #711

chitrangpatel opened this issue Feb 17, 2023 · 8 comments
Assignees
Milestone

Comments

@chitrangpatel
Copy link
Contributor

Tektoncd/Pipelines v0.45 introduced some breaking changes

eg. Removal of TaskRuns and Runs and only leaving ChildReferences are causing unit tests to fail.

chitrang-macbookpro:chains chitrang$ go test ./...
# github.com/tektoncd/chains/pkg/chains/signing/x509.test
ld: warning: -no_pie is deprecated when targeting new OS versions
ld: warning: non-standard -pagezero_size is deprecated when targeting macOS 13.0 or later
# github.com/tektoncd/chains/pkg/reconciler/pipelinerun
pkg/reconciler/pipelinerun/pipelinerun.go:75:58: pr.Status.TaskRuns undefined (type "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1".PipelineRunStatus has no field or method TaskRuns)
pkg/reconciler/pipelinerun/pipelinerun.go:75:89: pr.Status.Runs undefined (type "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1".PipelineRunStatus has no field or method Runs)
pkg/reconciler/pipelinerun/pipelinerun.go:76:39: pr.Status.TaskRuns undefined (type "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1".PipelineRunStatus has no field or method TaskRuns)

The source code in Chains needs to be updated to work with this change.

@chitrangpatel
Copy link
Contributor Author

/assign

chitrangpatel added a commit to chitrangpatel/chains that referenced this issue Feb 17, 2023
Tektoncd/pipelines release v0.45 came with [some breaking changes](tektoncd#711).
As a result, Chains needed to be updated. This PR
resolves those broken changes and updates to use tektoncd/pipeline v0.45.
chitrangpatel added a commit to chitrangpatel/chains that referenced this issue Feb 17, 2023
Tektoncd/pipelines release v0.45 came with [some breaking changes](tektoncd#711).
As a result, Chains needed to be updated. This PR
resolves those broken changes and updates to use tektoncd/pipeline v0.45.
chitrangpatel added a commit to chitrangpatel/chains that referenced this issue Feb 17, 2023
Tektoncd/pipelines release v0.45 came with [some breaking changes](tektoncd#711).
As a result, Chains needed to be updated. This PR
resolves those broken changes and updates to use tektoncd/pipeline v0.45.
chitrangpatel added a commit to chitrangpatel/chains that referenced this issue Feb 17, 2023
Tektoncd/pipelines release v0.45 came with [some breaking changes](tektoncd#711).
As a result, Chains needed to be updated. This PR
resolves those broken changes and updates to use tektoncd/pipeline v0.45.
chitrangpatel added a commit to chitrangpatel/chains that referenced this issue Feb 18, 2023
Tektoncd/pipelines release v0.45 came with [some breaking changes](tektoncd#711).
As a result, Chains needed to be updated. This PR
resolves those broken changes and updates to use tektoncd/pipeline v0.45.
chitrangpatel added a commit to chitrangpatel/chains that referenced this issue Feb 18, 2023
Tektoncd/pipelines release v0.45 came with [some breaking changes](tektoncd#711).
As a result, Chains needed to be updated. This PR
resolves those broken changes and updates to use tektoncd/pipeline v0.45.
chitrangpatel added a commit to chitrangpatel/chains that referenced this issue Feb 18, 2023
Tektoncd/pipelines release v0.45 came with [some breaking changes](tektoncd#711).
As a result, Chains needed to be updated. This PR
resolves those broken changes and updates to use tektoncd/pipeline v0.45.
tekton-robot pushed a commit that referenced this issue Feb 23, 2023
Tektoncd/pipelines release v0.45 came with [some breaking changes](#711).
As a result, Chains needed to be updated. This PR
resolves those broken changes and updates to use tektoncd/pipeline v0.45.
@wlynch wlynch added this to the v0.16.0 milestone Mar 28, 2023
@wlynch
Copy link
Member

wlynch commented Mar 28, 2023

@chitrangpatel now that tektoncd/pipeline#6206 was merged, are we able to re-add support for full status specs? 👀

@chitrangpatel
Copy link
Contributor Author

Good catch. I need to validate that. I will do that and report here again.

@chuangw6
Copy link
Member

seems like #712 has solved this. Is there anything left to do for this issue?

@wlynch
Copy link
Member

wlynch commented Apr 14, 2023

That solved the initial breakage, but we want to add back support so we don't break compatibility with older LTS sever versions.

@lcarva
Copy link
Contributor

lcarva commented Apr 26, 2023

I think we can close this now with #787

@wlynch
Copy link
Member

wlynch commented Apr 26, 2023

I think this is still waiting on re-adding support for non-ChildReference pipelines.

@chitrangpatel
Copy link
Contributor Author

chitrangpatel commented Apr 26, 2023

Opened a PR that added support to full-task-status again: #790 PTAL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants