Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump tektoncd/pipelines dependency to v0.45 #712

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Bump tektoncd/pipelines dependency to v0.45 #712

merged 1 commit into from
Feb 23, 2023

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Feb 17, 2023 •
edited
Loading

Tektoncd/pipelines release v0.45 came with some breaking changes. As a result, Chains needed to be updated. This PR
resolves those broken changes and updates to use tektoncd/pipeline v0.45.

Changes

  1. go dependency for tekton pipelines updated to v0.45.
  2. Pipeline controller version in CI e2e test also bumped to v0.45. This is because while the API did not contain pipelineRun.Status.taskruns, the pipeline controller version(v0.40) was producing pipeline pipeline run.Status.Taskruns and causing integration test to fail.
  3. Fixed additional e2e test which came as a result of bumping Tekton pipelines controller to v0.45.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Bump tektoncd/pipelines dependency to v0.45

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 17, 2023
@chitrangpatel
Copy link
Contributor Author

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 17, 2023
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 75.6% 82.9% 7.2

@chitrangpatel chitrangpatel marked this pull request as draft February 17, 2023 18:26
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2023
@chitrangpatel chitrangpatel force-pushed the bump-tekton-pipelines-0.45 branch from 69fc144 to e389290 Compare February 17, 2023 19:21
@chitrangpatel chitrangpatel marked this pull request as ready for review February 17, 2023 19:22
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2023
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 75.6% 82.9% 7.2

wlynch
wlynch approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Big shout out to @lcarva for making sure we were ready for this change! 🙇 🙇 🙇

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 17, 2023
@chitrangpatel
Copy link
Contributor Author

/retest

@chitrangpatel chitrangpatel force-pushed the bump-tekton-pipelines-0.45 branch from e389290 to 6cc4122 Compare February 17, 2023 23:37
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2023
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 75.6% 82.9% 7.2

@chitrangpatel chitrangpatel force-pushed the bump-tekton-pipelines-0.45 branch from 6cc4122 to f6cb704 Compare February 17, 2023 23:53
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 75.6% 82.9% 7.2

@chitrangpatel chitrangpatel force-pushed the bump-tekton-pipelines-0.45 branch from f6cb704 to 7025dcd Compare February 18, 2023 00:11
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 75.6% 82.9% 7.2

@chitrangpatel chitrangpatel force-pushed the bump-tekton-pipelines-0.45 branch from 7025dcd to 7bdd918 Compare February 18, 2023 00:31
@tekton-robot tekton-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 18, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 18, 2023
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 75.6% 82.9% 7.2

@chitrangpatel
Bump tektoncd/pipelines dependency to v0.45
1f3fcef 
Tektoncd/pipelines release v0.45 came with [some breaking changes](tektoncd#711).
As a result, Chains needed to be updated. This PR
resolves those broken changes and updates to use tektoncd/pipeline v0.45.
@chitrangpatel chitrangpatel force-pushed the bump-tekton-pipelines-0.45 branch from 7bdd918 to 1f3fcef Compare February 18, 2023 01:52
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/pipelinerun.go 75.6% 82.9% 7.2

@chitrangpatel chitrangpatel requested review from wlynch and removed request for priyawadhwa and chuangw6 February 18, 2023 02:55
@chitrangpatel
Copy link
Contributor Author

@wlynch to get the e2e tests working, I had to upgrade the CI pipelines controller to v0.45 as well (see PR description Changes for details). PTAL. If you're happy, it can now be lgtm-ed

@wlynch wlynch mentioned this pull request Feb 21, 2023
Closed
wlynch
wlynch reviewed Feb 21, 2023
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending response from pipeline maintainers for how they want to move forward with the breaking change (if the field ends up being rolled back we can keep the reconciler bits in to retain support for LTS versions). If no solid answer by EOW I'll merge this as-is.

@chitrangpatel chitrangpatel mentioned this pull request Feb 22, 2023
Merged
6 tasks
@chitrangpatel
Copy link
Contributor Author

LGTM pending response from pipeline maintainers for how they want to move forward with the breaking change (if the field ends up being rolled back we can keep the reconciler bits in to retain support for LTS versions). If no solid answer by EOW I'll merge this as-is.

Sounds good!
/hold until EOW/reply from pipeline maintainers.

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2023
@wlynch
Copy link
Member

wlynch commented Feb 23, 2023

Sounds like we're going to rollback the change in tektoncd/pipeline#6206

#716 to add running chains e2e tests against multiple Pipelines versions.

/hold cancel
/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 23, 2023
@tekton-robot tekton-robot merged commit e813ece into tektoncd:main Feb 23, 2023
@chuangw6 chuangw6 mentioned this pull request Apr 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlynch wlynch wlynch approved these changes

Assignees

@wlynch wlynch

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chitrangpatel @tekton-robot @wlynch