Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Command for Pipeline, Resource, and Task Resources #193

Closed
danielhelfand opened this issue Jul 31, 2019 · 10 comments
Closed

Delete Command for Pipeline, Resource, and Task Resources #193

danielhelfand opened this issue Jul 31, 2019 · 10 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@danielhelfand
Copy link
Member

danielhelfand commented Jul 31, 2019

This issue is a feature request for the ability to delete custom resource definitions for tekton.dev resources on a Kubernetes cluster. These resources include:

  • Pipeline
  • Resource
  • Task

Currently, a user must use a second tool to delete these custom resources, such as kubectl or oc. Being able to do this directly through tkn would help with having a user not have to go back and forth with another tool while using tkn.

Expected Behavior

The delete command should remove a particular resource from a Kubernetes namespace.

Example with Pipeline:

tkn pipeline delete pipeline_name

  • This should use the name of the already created pipeline to find and remove the pipeline from the cluster namespace

Additional Info

Since these features are already implemented in other Kubernetes tools, the question is how what should tkn overlap with for these other tools in terms of functionality versus leave to the other tools completely.

In my opinion, I think it makes sense in this case to have the ability to also delete through tkn along with other Kubernetes tools.

@danielhelfand
Copy link
Member Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 31, 2019
@vdemeester vdemeester added this to the 0.3.0 🐱 milestone Jul 31, 2019
@vdemeester vdemeester modified the milestones: 0.3.0 🐱, 0.4.0 🐱 Aug 21, 2019
@16yuki0702
Copy link
Member

Could I take a remaining tasks (Pipeline, Task) ??
I wrote a command for Resource on #222

@danielhelfand
Copy link
Member Author

@16yuki0702 Go for it!

@16yuki0702
Copy link
Member

@danielhelfand Thanks!!

@16yuki0702
Copy link
Member

/assign

@chmouel
Copy link
Member

chmouel commented Aug 23, 2019

@16yuki0702 Thanks for working on this, can you confirm you are working on all the delete resources? I.e: Task, TaskRun, Pipeline,PipelineRun

Thanks,

@16yuki0702
Copy link
Member

@chmouel yes, I'm working on all resources (Task, TaskRun, Pipeline, PipelineRun).
I'm sorry, I missed writing TaskRun, PipelineRun 😅

Thanks !!

@16yuki0702
Copy link
Member

I thinks this is completed.
Could I close it??

@danielhelfand
Copy link
Member Author

Yup, looks like delete is covered for every resource. Thanks, @16yuki0702!

@16yuki0702
Copy link
Member

@danielhelfand Thank you for your confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants