Add delete taskrun command #238
Conversation
|
Hi @16yuki0702. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
needs-ok-to-test
|
/ok-to-test |
tekton-robot
added
ok-to-test
|
The following is the coverage report on pkg/.
|
|
/retest |
|
same comment as #236 (comment) @16yuki0702 any chances we can have the same as #235, defaulting to ask if we really want to delete unless -f ? |
16yuki0702
force-pushed
the
add_delete_taskrun_command
branch
from
5667ffd to
e17f61f
Compare
|
The following is the coverage report on pkg/.
|
|
/retest |
1 similar comment
|
/retest |
|
The CI error seems unreleated to your code, i have added an issue here tektoncd/pipeline#1252 |
I got it, thanks!! |
|
/retest |
| ### Examples | ||
|
|
||
|
|
||
| # Delete a TaskRun of name 'foo' in namespace 'bar' |
There was a problem hiding this comment.
I think there is no need to have a H1 for Delete a TaskRun of name 'foo' in namespace 'bar'.
There was a problem hiding this comment.
Thank you for your review!!
another docs also have a H1 these. https://github.com/tektoncd/cli/blob/master/docs/cmd/tkn_resource_describe.md
I think we need make a rule about document format.
(after that, we need correct these!)
| # Delete a TaskRun of name 'foo' in namespace 'bar' | ||
| tkn taskrun delete foo -n bar | ||
|
|
||
| tkn tr rm foo -n bar", |
There was a problem hiding this comment.
Why there is a single "?
There was a problem hiding this comment.
oh I didn't realize it, thanks!!
I should correct it together with other documents, so how about making another PR after this??
pkg/cmd/taskrun/delete.go
Outdated
| } | ||
|
|
||
| if err := cs.Tekton.TektonV1alpha1().TaskRuns(p.Namespace()).Delete(trName, &metav1.DeleteOptions{}); err != nil { | ||
| return fmt.Errorf("Failed to delete taskrun %q: %s", trName, err) |
There was a problem hiding this comment.
Error string should not be capitalized.
There was a problem hiding this comment.
Hmm, I found that there are a lot of Capitalized error (I run git grep fmt.Errorf)
I think It depends on project rule (if we really need to make it).
how about ??
There was a problem hiding this comment.
There was a problem hiding this comment.
oh I didn't know it, thank you very much!!
I should correct it at least my PR 👍
There was a problem hiding this comment.
Interesting that golangci doesnt pick this up, i have created #248
pkg/cmd/taskrun/delete.go
Outdated
| func deleteTaskRun(s *cli.Stream, p cli.Params, trName string) error { | ||
| cs, err := p.Clients() | ||
| if err != nil { | ||
| return fmt.Errorf("Failed to create tekton client") |
There was a problem hiding this comment.
Error string should not be capitalized.
pkg/cmd/taskrun/delete.go
Outdated
| if t == "y" { | ||
| break | ||
| } else if t == "n" { | ||
| return fmt.Errorf("Canceled deleting taskrun %q", trName) |
There was a problem hiding this comment.
Error string should not be capitalized.
|
The following is the coverage report on pkg/.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 16yuki0702, khrm, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
Add deleting the taskrun feature for #193.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes