-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delete resource command #222
Add delete resource command #222
Conversation
Hi @16yuki0702. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
The following is the coverage report on pkg/.
|
pkg/cmd/pipelineresource/delete.go
Outdated
} | ||
|
||
if err := cs.Tekton.TektonV1alpha1().PipelineResources(p.Namespace()).Delete(preName, &metav1.DeleteOptions{}); err != nil { | ||
return fmt.Errorf("Failed to delete pipelineresource %q", preName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may want to provide a bit more details as to why the deletion failed by printing the err
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree, thanks!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Some minor suggestions.
4d28e3e
to
86ece00
Compare
The following is the coverage report on pkg/.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@16yuki0702 The pr also need to include the man pages and the doc page, see
- other sub-commands like
pipeline start
documented under docs/reference. - make docs and make man
@sthaha oh... Thank you so much! I'll add the documents. |
86ece00
to
b306f4c
Compare
The following is the coverage report on pkg/.
|
@sthaha I added the documents, thanks!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @16yuki0702 🤗
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 16yuki0702, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sthaha @vdemeester Thank for reviews!! |
Changes
Add deleting the pipelineresource feature for #193.
Make PR not too big, I started only pipelineresource.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes