Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe Subcommands for Condition, EventListener, TriggerBinding, ClusterTriggerBinding, TriggerTemplate, and ClusterTask #594

Closed
6 tasks done
danielhelfand opened this issue Jan 13, 2020 · 7 comments
Closed
6 tasks done

Describe Subcommands for Condition, EventListener, TriggerBinding, ClusterTriggerBinding, TriggerTemplate, and ClusterTask #594

danielhelfand opened this issue Jan 13, 2020 · 7 comments
Assignees
@savitaashture @supra08
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
0.9.0 🐺

Comments

@danielhelfand
Copy link
Member

danielhelfand commented Jan 13, 2020 •
edited by piyush-garg
Loading

The following commands do not include describe subcommands: Condition, EventListener, ClusterTriggerBinding, TriggerBinding, TriggerTemplate, and ClusterTask.

These commands should follow the format we use for other describe commands (e.g. tkn task describe).

Shorthand for the command should be desc as is consistent with other describe subcommands.

The resource to be described is passed in as an argument from the command line.

Examples:

Describe condition named condition-name:
tkn condition describe condition-name

Shorthand for describe eventlistener named el-name:
tkn eventlistener desc el-name

Progress:
@danielhelfand
Copy link
Member Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 13, 2020
@danielhelfand danielhelfand mentioned this issue Jan 17, 2020
Merged
5 tasks
@danielhelfand danielhelfand changed the title Describe Subcommands for Condition, EventListener, TriggerBinding, and TriggerTemplate Describe Subcommands for Condition, EventListener, TriggerBinding, TriggerTemplate, and ClusterTask Jan 17, 2020
@danielhelfand danielhelfand added this to the 0.8.0 🐯 milestone Feb 4, 2020
@vdemeester vdemeester modified the milestones: 0.8.0 🐯, 0.9.0 🐺 Feb 27, 2020
@vdemeester vdemeester added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Mar 3, 2020
@supra08
Copy link

supra08 commented Mar 11, 2020

@danielhelfand I would like to work on this issue.

@vdemeester
Copy link
Member

/assign @supra08

@danielhelfand
Copy link
Member Author

Thanks @supra08!

@savitaashture savitaashture mentioned this issue Apr 17, 2020
Merged
4 tasks
@danielhelfand
Copy link
Member Author

Updated list for #912

@danielhelfand danielhelfand changed the title Describe Subcommands for Condition, EventListener, TriggerBinding, TriggerTemplate, and ClusterTask Describe Subcommands for Condition, EventListener, TriggerBinding, ClusterTriggerBinding, TriggerTemplate, and ClusterTask Apr 21, 2020
@savitaashture
Copy link
Contributor

/assign

This was referenced Apr 21, 2020
Merged
Merged
Merged
@piyush-garg piyush-garg mentioned this issue Apr 27, 2020
Merged
4 tasks
piyush-garg added a commit to piyush-garg/cli that referenced this issue Apr 27, 2020
@piyush-garg
Add description command for condition
e5432fd 
This will add description command for
condition. It also supports output
in different format

Add docs and test

Part of tektoncd#594
tekton-robot pushed a commit that referenced this issue Apr 28, 2020
@piyush-garg @tekton-robot
Add description command for condition
045be20 
This will add description command for
condition. It also supports output
in different format

Add docs and test

Part of #594
@piyush-garg
Copy link
Contributor

/close

All subcommands done. Closing this cc @vdemeester @danielhelfand @savitaashture

@nkakkar81 nkakkar81 mentioned this issue Apr 30, 2020
Merged
@savitaashture savitaashture mentioned this issue May 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@savitaashture savitaashture

@supra08 supra08

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
0.9.0 🐺
Development

No branches or pull requests
6 participants
@vdemeester @savitaashture @piyush-garg @supra08 @danielhelfand @tekton-robot