Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tkn clustertask describe Command #624

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Add tkn clustertask describe Command #624

merged 1 commit into from
Jan 20, 2020

Conversation

danielhelfand
Copy link
Member

@danielhelfand danielhelfand commented Jan 17, 2020 •
edited
Loading

Part of #594

Adding a clustertask describe command. Follows a similar pattern to tkn task desc. May need to rebase this based on #611 and add test for unnamed steps.

Can also switch to golden file method for testing.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

Release Notes

Add tkn ct describe command to describe a clustertask

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 17, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/clustertask/describe.go Do not exist 80.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/clustertask/describe.go Do not exist 80.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/clustertask/describe.go Do not exist 80.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/clustertask/describe.go Do not exist 85.0%

@danielhelfand
Copy link
Member Author

/test pull-tekton-cli-integration-tests

2 similar comments
@danielhelfand
Copy link
Member Author

/test pull-tekton-cli-integration-tests

@danielhelfand
Copy link
Member Author

/test pull-tekton-cli-integration-tests

vdemeester
vdemeester requested changes Jan 20, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielhelfand can you use golden files like the other ones (see #623 ) ?

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2020
@danielhelfand
Copy link
Member Author

@danielhelfand can you use golden files like the other ones (see #623 ) ?

/hold

🏅 files added

vdemeester
vdemeester reviewed Jan 20, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

pkg/cmd/clustertask/describe_test.go Outdated
input: seeds[0],
inputStream: nil,
wantError: false,
want: `Name: clustertask-one-everything
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are not needed anymore 👼

pkg/cmd/clustertask/describe_test.go Outdated
input: seeds[0],
inputStream: nil,
wantError: false,
want: `Name: clustertask-full
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are not needed anymore 👼

pkg/cmd/clustertask/describe_test.go Outdated
input: seeds[0],
inputStream: nil,
wantError: false,
want: `Name: clustertask-justname
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are not needed anymore 👼

Copy link
Member Author

@danielhelfand danielhelfand Jan 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just forgot! I'll take them out.

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2020
vdemeester
vdemeester approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2020
@tekton-robot tekton-robot merged commit c0699e0 into tektoncd:master Jan 20, 2020
@danielhelfand danielhelfand deleted the clustertask_desc branch January 21, 2020 14:20
@danielhelfand danielhelfand mentioned this pull request Apr 21, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@hrishin hrishin Awaiting requested review from hrishin

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielhelfand @tekton-robot @vdemeester @googlebot