Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGSEV on pipelinerun logs #775

Closed
afrittoli opened this issue Mar 4, 2020 · 7 comments
Closed

SIGSEV on pipelinerun logs #775

afrittoli opened this issue Mar 4, 2020 · 7 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@afrittoli
Copy link
Member

Version and Operating System

tkn Version:

Client version: 0.8.0
Pipeline version: v0.10.1

Operating System:
MacOS Catalina

Expected Behavior

I can view logs of the pipeline

Actual Behavior

$ tkn pr logs tekton-noop-check-fcxr6 -n tektonci
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1d68c24]

goroutine 1 [running]:
github.com/tektoncd/cli/pkg/helper/log.(*Reader).readAvailablePipelineLogs(0xc0000cac80, 0xc00000ad20, 0x17, 0x0, 0x0, 0x0)
	/workspace/src/github.com/tektoncd/cli/pkg/helper/log/pipeline_reader.go:90 +0xc4
github.com/tektoncd/cli/pkg/helper/log.(*Reader).readPipelineLog(0xc0000cac80, 0x8, 0x21cfec8, 0x7ffeefbff51c, 0xc0003c38f0)
	/workspace/src/github.com/tektoncd/cli/pkg/helper/log/pipeline_reader.go:41 +0x13d
github.com/tektoncd/cli/pkg/helper/log.(*Reader).Read(0xc0000cac80, 0x8, 0xc0001b92c0, 0xc0000cac80, 0x0)
	/workspace/src/github.com/tektoncd/cli/pkg/helper/log/reader.go:77 +0xb8
github.com/tektoncd/cli/pkg/cmd/pipelinerun.Run(0xc0001b92c0, 0xc0002ee000, 0x0)
	/workspace/src/github.com/tektoncd/cli/pkg/cmd/pipelinerun/logs.go:105 +0x81
github.com/tektoncd/cli/pkg/cmd/pipelinerun.logCommand.func1(0xc00030f8c0, 0xc000324e70, 0x1, 0x3, 0x0, 0x0)
	/workspace/src/github.com/tektoncd/cli/pkg/cmd/pipelinerun/logs.go:78 +0x1ba
github.com/spf13/cobra.(*Command).execute(0xc00030f8c0, 0xc000324de0, 0x3, 0x3, 0xc00030f8c0, 0xc000324de0)
	/workspace/pkg/mod/github.com/chmouel/[email protected]/command.go:834 +0x460
github.com/spf13/cobra.(*Command).ExecuteC(0xc00029c840, 0xc0002ee000, 0xc00029c840, 0xc00004c118)
	/workspace/pkg/mod/github.com/chmouel/[email protected]/command.go:922 +0x2fb
github.com/spf13/cobra.(*Command).Execute(...)
	/workspace/pkg/mod/github.com/chmouel/[email protected]/command.go:872
main.main()
	/workspace/src/github.com/tektoncd/cli/cmd/tkn/main.go:29 +0x4b

Additional Info

I suspect this is because the pipeline definition is embedded with pipelineSpec

Spec of the pipelinerun:

apiVersion: tekton.dev/v1alpha1
kind: PipelineRun
metadata:
  creationTimestamp: "2020-03-04T14:57:11Z"
  generation: 1
  labels:
    prow.k8s.io/build-id: 6c7c2700-5e28-11ea-9bdf-639ed7fddffb
    tekton.dev/check-name: tekton-noop-check
    tekton.dev/eventlistener: tekton-ci-webhook
    tekton.dev/kind: ci
    tekton.dev/pipeline: tekton-noop-check-fcxr6
    tekton.dev/pr-number: "254"
    tekton.dev/trigger: pull-request-trigger
    tekton.dev/triggers-eventid: 8mnlv
  name: tekton-noop-check-fcxr6
  namespace: tektonci
  resourceVersion: "57546407"
  selfLink: /apis/tekton.dev/v1alpha1/namespaces/tektonci/pipelineruns/tekton-noop-check-fcxr6
  uid: c13de874-f41e-40ac-92b0-42cab6b17a6a
spec:
  pipelineSpec:
    resources:
    - name: source
      type: git
    - name: starttrigger
      type: cloudEvent
    - name: endtrigger
      type: cloudEvent
    tasks:
    - name: check-reset
      params:
      - name: checkName
        value: tekton-noop-check
      resources:
        outputs:
        - name: trigger
          resource: starttrigger
      taskRef:
        name: tekton-ci-reset-check-status
    - name: ci-job
      params:
      - name: message
        value: 'BuildUUID#: 6c7c2700-5e28-11ea-9bdf-639ed7fddffb, Package: tektoncd/plumbing,
          Repo: $(params.gitRepository, Revision: 24e4ebb02519a8433a23551c9cc4fb4af8a8d1eb'
      resources:
        inputs:
        - name: source
          resource: source
        outputs:
        - name: endtrigger
          resource: endtrigger
      taskRef:
        name: tekton-noop
  resources:
  - name: source
    resourceSpec:
      params:
      - name: revision
        value: 24e4ebb02519a8433a23551c9cc4fb4af8a8d1eb
      - name: url
        value: https://https://github.com/tektoncd/plumbing
      type: git
  - name: starttrigger
    resourceRef:
      name: github-check-start
  - name: endtrigger
    resourceRef:
      name: github-check-done
  serviceAccountName: tekton-ci-jobs
  timeout: 1h0m0s
status:
  completionTime: "2020-03-04T14:57:19Z"
  conditions:
  - lastTransitionTime: "2020-03-04T14:57:17Z"
    message: TaskRun tekton-noop-check-fcxr6-ci-job-jrwtz has failed
    reason: Failed
    status: "False"
    type: Succeeded
  startTime: "2020-03-04T14:57:11Z"
  taskRuns:
    tekton-noop-check-fcxr6-check-reset-mwv7n:
      pipelineTaskName: check-reset
      status:
        cloudEvents:
        - status:
            condition: Sent
            message: ""
            retryCount: 1
            sentAt: "2020-03-04T14:57:19Z"
          target: http://el-github-check-start.tektonci:8080
        completionTime: "2020-03-04T14:57:19Z"
        conditions:
        - lastTransitionTime: "2020-03-04T14:57:19Z"
          message: All Steps have completed executing
          reason: Succeeded
          status: "True"
          type: Succeeded
        podName: tekton-noop-check-fcxr6-check-reset-mwv7n-pod-28wps
        startTime: "2020-03-04T14:57:11Z"
        steps:
        - container: step-noop
          imageID: docker-pullable://busybox@sha256:edafc0a0fb057813850d1ba44014914ca02d671ae247107ca70c94db686e7de6
          name: noop
          terminated:
            containerID: docker://9b1704d9a47ee8d5db0a5c2dc9caefefb75195057a6a6c6c3174dc3504a8e689
            exitCode: 0
            finishedAt: "2020-03-04T14:57:18Z"
            reason: Completed
            startedAt: "2020-03-04T14:57:18Z"
        - container: step-create-dir-trigger-6r4pp
          imageID: docker-pullable://busybox@sha256:edafc0a0fb057813850d1ba44014914ca02d671ae247107ca70c94db686e7de6
          name: create-dir-trigger-6r4pp
          terminated:
            containerID: docker://9e7cdc2935f059ccd52deb8f7b0f0d758d8af9d7a5e9f1a4b5d76f2aed4c1534
            exitCode: 0
            finishedAt: "2020-03-04T14:57:17Z"
            reason: Completed
            startedAt: "2020-03-04T14:57:17Z"
    tekton-noop-check-fcxr6-ci-job-jrwtz:
      pipelineTaskName: ci-job
      status:
        cloudEvents:
        - status:
            condition: Sent
            message: ""
            retryCount: 1
            sentAt: "2020-03-04T14:57:17Z"
          target: http://el-github-check-done.tektonci:8080
        completionTime: "2020-03-04T14:57:17Z"
        conditions:
        - lastTransitionTime: "2020-03-04T14:57:17Z"
          message: '"step-git-source-source-kvqqp" exited with code 1 (image: "docker-pullable://gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/git-init@sha256:18ffa2bfc14b1fa6d39f62271beacf6bbc38e7cd2e255184dec477c2936270bc");
            for logs run: kubectl -n tektonci logs tekton-noop-check-fcxr6-ci-job-jrwtz-pod-tm2rb
            -c step-git-source-source-kvqqp'
          reason: Failed
          status: "False"
          type: Succeeded
        podName: tekton-noop-check-fcxr6-ci-job-jrwtz-pod-tm2rb
        startTime: "2020-03-04T14:57:11Z"
        steps:
        - container: step-noop
          imageID: docker-pullable://busybox@sha256:edafc0a0fb057813850d1ba44014914ca02d671ae247107ca70c94db686e7de6
          name: noop
          terminated:
            containerID: docker://c6343b395ac30d72be1aa10ed67e83f251523e334e650f2af955bbc98d8feb49
            exitCode: 1
            finishedAt: "2020-03-04T14:57:16Z"
            reason: Error
            startedAt: "2020-03-04T14:57:15Z"
        - container: step-git-source-source-kvqqp
          imageID: docker-pullable://gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/git-init@sha256:18ffa2bfc14b1fa6d39f62271beacf6bbc38e7cd2e255184dec477c2936270bc
          name: git-source-source-kvqqp
          terminated:
            containerID: docker://420d6648b5a80d0f4e6a0bfc7d70a2d34c62ddaf37f25a9a0cc1971ebbaf4095
            exitCode: 1
            finishedAt: "2020-03-04T14:57:16Z"
            reason: Error
            startedAt: "2020-03-04T14:57:16Z"
        - container: step-create-dir-endtrigger-4x7nm
          imageID: docker-pullable://busybox@sha256:edafc0a0fb057813850d1ba44014914ca02d671ae247107ca70c94db686e7de6
          name: create-dir-endtrigger-4x7nm
          terminated:
            containerID: docker://d898391ac0a26ce97e2dc75084cfd2d65be38f44e2bdba169f89d30c9479fcc1
            exitCode: 0
            finishedAt: "2020-03-04T14:57:16Z"
            reason: Completed
            startedAt: "2020-03-04T14:57:16Z"
@danielhelfand danielhelfand added the kind/bug Categorizes issue or PR as related to a bug. label Mar 4, 2020
@16yuki0702
Copy link
Member

I suspect this is because the pipeline definition is embedded with pipelineSpec

yes, I can reprduce this bug using embedded pipelineSpec.
I'll fix this.

@16yuki0702
Copy link
Member

/assign

@16yuki0702
Copy link
Member

maybe this is same #603

@siamaksade
Copy link

I ran into the same issue with 0.8.0 but master seem to have resolved it already:

0.8.0:

$ tkn pr describe condtional-pr
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x1d33a86]

goroutine 1 [running]:
github.com/tektoncd/cli/pkg/helper/pipelinerun/description.taskrunList.Less(0xc0004268d0, 0x2, 0x2, 0x1, 0x0, 0xc0003d3a10)
	/workspace/src/github.com/tektoncd/cli/pkg/helper/pipelinerun/description/description.go:85 +0x66
sort.insertionSort(0x235e680, 0xc0003fb220, 0x0, 0x2)
	/usr/local/go/src/sort/sort.go:27 +0xc4
sort.quickSort(0x235e680, 0xc0003fb220, 0x0, 0x2, 0x4)
	/usr/local/go/src/sort/sort.go:209 +0x201
sort.Sort(0x235e680, 0xc0003fb220)
	/usr/local/go/src/sort/sort.go:218 +0x79
github.com/tektoncd/cli/pkg/helper/pipelinerun/description.PrintPipelineRunDescription(0xc0003d3d40, 0x7ffeefbff980, 0xd, 0x23761a0, 0xc0002dc100, 0x0, 0x0)
	/workspace/src/github.com/tektoncd/cli/pkg/helper/pipelinerun/description/description.go:126 +0x883
github.com/tektoncd/cli/pkg/cmd/pipelinerun.describeCommand.func1(0xc000300dc0, 0xc0003106c0, 0x1, 0x1, 0x0, 0x0)
	/workspace/src/github.com/tektoncd/cli/pkg/cmd/pipelinerun/describe.go:73 +0x20b
github.com/spf13/cobra.(*Command).execute(0xc000300dc0, 0xc000310690, 0x1, 0x1, 0xc000300dc0, 0xc000310690)
	/workspace/pkg/mod/github.com/chmouel/[email protected]/command.go:834 +0x460
github.com/spf13/cobra.(*Command).ExecuteC(0xc0002d62c0, 0xc0002dc100, 0xc0002d62c0, 0xc0000460b8)
	/workspace/pkg/mod/github.com/chmouel/[email protected]/command.go:922 +0x2fb
github.com/spf13/cobra.(*Command).Execute(...)
	/workspace/pkg/mod/github.com/chmouel/[email protected]/command.go:872
main.main()
	/workspace/src/github.com/tektoncd/cli/cmd/tkn/main.go:29 +0x4b

master:

# ./bin/tkn pr describe condtional-pr
Name:              condtional-pr
Namespace:         demo
Pipeline Ref:      conditional-pipeline
Service Account:   default
Timeout:           1h0m0s

🌡️  Status

STARTED        DURATION   STATUS
1 minute ago   1 minute   Succeeded

📦 Resources

 NAME            RESOURCE REF
 ∙ source-repo   pipeline-git

⚓ Params

 No params

🗂  Taskruns

 NAME                                      TASK NAME           STARTED          DURATION     STATUS
 ∙ condtional-pr-then-check-fxcrr          then-check          52 seconds ago   14 seconds   Succeeded
 ∙ condtional-pr-first-create-file-2qw6m   first-create-file   1 minute ago     41 seconds   Succeeded

@16yuki0702
Copy link
Member

I ran into the same issue with 0.8.0 but master seem to have resolved it already:

maybe you mean about pr describe ?
(and this PR is related ? #780)

this issue about pr logs.

16yuki0702 added a commit to 16yuki0702/cli that referenced this issue Mar 9, 2020
Related issue is tektoncd#775

When user difines embedded pipeline in pipelinerun,
pr.Spec.PipelineRef is nil so SIGSEGV happen.

changing to Checking both pr.Spec.PipelineRef and pr.Spec.PipelineSpec,
And getting tasks from either.
tekton-robot pushed a commit that referenced this issue Mar 9, 2020
Related issue is #775

When user difines embedded pipeline in pipelinerun,
pr.Spec.PipelineRef is nil so SIGSEGV happen.

changing to Checking both pr.Spec.PipelineRef and pr.Spec.PipelineSpec,
And getting tasks from either.
@danielhelfand
Copy link
Member

The tkn pr describe issue is unrelated to #780. It seems similar to what was reported in #584 and resolved in #586.

If that's occurring in v0.8.0 and can be reproduced, then that should be looked into further as #586 was part of v0.7.1.

@danielhelfand
Copy link
Member

Closing this from #781

piyush-garg added a commit that referenced this issue Apr 29, 2020
#754 | [16yuki0702] A little Refactoring log reader. changes are following. | 2020/02/28-04:53
#761 | [Daniel Helfand] improve keep description and unit tests for prompts | 2020/02/28-08:29
#759 | [Vincent Demeester] Add support for yubikey in debbuild 🦌 | 2020/02/28-08:41
#762 | [Daniel Helfand] version v0.8.0 README update | 2020/03/02-02:51
#750 | [Vibhav Bobade] - Add Timeout Description to TaskRun and PipelineRun | 2020/03/02-03:36
#751 | [Vibhav Bobade] Remove -t timeout shorthand from tkn task start | 2020/03/02-03:36
#760 | [Vincent Demeester] Use `#!/usr/bin/env bash` instead of `bin/bash` 👼 | 2020/03/02-03:50
#760 | [Vincent Demeester] Use scripts for goreleaser task 👼 | 2020/03/02-03:50
#756 | [Vincent Demeester] Move version out of the helper package 🌿 | 2020/03/02-07:56
null | [Vincent Demeester] Move log out of the helper package 🌿 | 2020/03/02-07:56
null | [Vincent Demeester] Move params out of the helper package 🌿 | 2020/03/02-07:56
null | [Vincent Demeester] Move options out of the helper package 🌿 | 2020/03/02-07:56
null | [Vincent Demeester] Move labels out of the helper package 🌿 | 2020/03/02-07:56
null | [Vincent Demeester] Move names out of the helper package 🌿 | 2020/03/02-07:56
null | [Vincent Demeester] Move file out of the helper package 🌿 | 2020/03/02-07:56
null | [Vincent Demeester] Move validate out of the helper package 🌿 | 2020/03/02-07:56
null | [Vincent Demeester] Move pods out of the helper package 🌿 | 2020/03/02-07:56
null | [Vincent Demeester] Move deleter out of the helper package 🌿 | 2020/03/02-07:56
null | [Vincent Demeester] Move task out of the helper package 🌿 | 2020/03/02-07:56
null | [Vincent Demeester] Move taskrun out of the helper package 🌿 | 2020/03/02-07:56
null | [Vincent Demeester] Move pipelinerun out of the helper package 🌿 | 2020/03/02-07:56
null | [Vincent Demeester] Move pipeline out of the helper package 🌿 | 2020/03/02-07:56
null | [Vincent Demeester] Fix logs_test.go import 😇 | 2020/03/02-07:56
null | [Vincent Demeester] Run goimports 😅 | 2020/03/02-07:56
null | [Vincent Demeester] Re-generate the docs 📖 | 2020/03/02-07:56
null | [Piyush Garg] Remove the name param in cluster resource creation | 2020/03/03-07:50
null | [Pavol Pitonak] Fix several typos | 2020/03/04-08:39
null | [Pradeep Kumar] Change timeout to string for tkn task start | 2020/03/05-09:04
null | [Daniel Helfand] use text/template instead of html/template for pipelinerun describe | 2020/03/06-03:17
null | [Vincent Demeester] Bump to v0.11.0-rc1 🚌 | 2020/03/06-11:30
null | [16yuki0702] Fix SIGSEGV on pipelinerun logs. Related issue is #775 | 2020/03/08-21:24
null | [Vincent Demeester] Add tkn official image on contrib 🖌 | 2020/03/09-06:59
null | [Daniel Helfand] add sidecar status to tkn tr describe | 2020/03/10-08:18
null | [Daniel Helfand] convert --all to delete all pipelines and tasks in namespace | 2020/03/10-08:41
null | [Vibhav Bobade] Add flag to reverse sort taskruns/pipelineruns | 2020/03/10-08:41
null | [pthangad] Added Pipeline E2E tests | 2020/03/10-09:40
null | [Dibyo Mukherjee] Update Triggers dependency for CLI | 2020/03/11-03:15
null | [Piyush Garg] Bump to tektoncd/pipeline 0.11.0-rc2 | 2020/03/11-11:31
null | [Daniel Helfand] change pipelineruns to taskruns for tkn tr delete --keep desc | 2020/03/13-01:19
null | [Daniel Helfand] change status check for pr and tr cancel for color | 2020/03/13-01:37
null | [Piyush Garg] Add description to task, clustertask, condition list | 2020/03/13-03:32
null | [pthangad] Build tkn binary before running cli tests | 2020/03/13-04:24
null | [Piyush Garg] Add description to describe command | 2020/03/13-11:29
null | [Daniel Helfand] change tr and pr sorting from sort.Slice to sort.Sort | 2020/03/16-03:35
null | [Daniel Helfand] remove duplicate error message when deleting nonexistent resource | 2020/03/17-10:58
null | [pthangad] Add license to e2e tests | 2020/03/18-04:53
null | [Pradeep Kumar] Refactor task list cmd with v1beta1 support | 2020/03/18-10:18
null | [Daniel Helfand] add warning message in v0.9.0 about clustertask timeout | 2020/03/20-02:59
null | [Vibhav Bobade] Add flag to list TaskRuns from all namespaces | 2020/03/20-09:37
null | [Vibhav Bobade] Add flag to list PipelineRuns from all namespaces | 2020/03/20-09:37
null | [Vibhav Bobade] Update e2e to support TaskRun and PipelineRun List to use templates | 2020/03/20-09:37
null | [Daniel Helfand] start pipelinerun from local or remote file | 2020/03/20-10:37
null | [Pradeep Kumar] Add v1beta1 support for clustertask list | 2020/03/23-10:56
null | [Pradeep Kumar] Adds test for list v1beta1 | 2020/03/23-11:42
null | [Pradeep Kumar] v1beta1 support for taskrun list | 2020/03/24-11:26
null | [Daniel Helfand] fix test failure from go v1.14.0 update | 2020/03/26-06:43
null | [Pradeep Kumar] v1beta1 support for pipeline list cmd | 2020/03/26-12:18
null | [Vincent Demeester] Add RELEASE_VERSION build-arg to the image 📟 | 2020/03/26-15:50
null | [Pradeep Kumar] v1beta1 support for taskrun delete | 2020/03/27-03:22
null | [Pradeep Kumar] v1beta1 support for pipelinerun list & delete cmd | 2020/03/27-08:44
null | [Vincent Demeester] Sort resources in start subcommands 🌮 | 2020/03/30-07:14
null | [Vincent Demeester] Add ROADMAP.md 🤖 | 2020/03/30-07:38
null | [Khurram Baig] Add workspace option to pipeline start | 2020/03/30-07:55
null | [Vibhav Bobade] Add --noheaders flag to taskrun list subcommand | 2020/03/31-01:35
null | [Vibhav Bobade] Add --noheaders flag to pipelinerun list subcommand | 2020/03/31-01:35
null | [savitaashture] Fix tkn pipeline version issue | 2020/03/31-02:09
null | [Pradeep Kumar] remove redundant code | 2020/03/31-02:43
null | [Pradeep Kumar] v1beta1 support for task delete command | 2020/03/31-03:05
null | [Pradeep Kumar] v1beta1 support for pipeline delete command | 2020/03/31-04:43
null | [Khurram Baig] Add workspace to task start | 2020/03/31-07:19
null | [Daniel Helfand] clustertriggerbinding list command | 2020/03/31-07:47
null | [Daniel Helfand] add tkn ctb delete command | 2020/04/01-02:08
null | [Yulia Gaponenko] Add tekton cli build for s390x architecture This will add s390x target to Makefile and to .goreleaser.yaml | 2020/04/01-02:39
null | [Pradeep Kumar] v1beta1 support for clustertask delete | 2020/04/01-04:28
null | [Pradeep Kumar] fix typo and change function name | 2020/04/01-05:41
null | [Vincent Demeester] Import docs/README.md from website | 2020/04/01-07:55
null | [savitaashture] Add changes to display TaskRun and PipelineRun labels | 2020/04/02-02:27
null | [savitaashture] fix review comments | 2020/04/02-02:27
null | [Piyush Garg] Bump to tektoncd/pipeline v0.11.0 | 2020/04/02-07:25
null | [Daniel Helfand] warning messages about removing create -f | 2020/04/02-23:31
null | [Piyush Garg] Bump tektoncd/triggers to v0.4.0-rc1 | 2020/04/03-12:11
null | [Pradeep Kumar] v1beta1 support for task and taskrun logs command | 2020/04/03-18:03
null | [Pradeep Kumar] adds test for v1beta1 address review comments | 2020/04/03-18:03
null | [Daniel Helfand] add pradeepitm12 to OWNERS | 2020/04/04-09:02
null | [Pradeep Kumar] v1beta1 support for pipeline and run logs command | 2020/04/06-08:50
null | [Daniel Helfand] use timeout of --last or --use-pipelinerun/--use-taskrun | 2020/04/06-09:18
null | [Pradeep Kumar] v1beta1 support for taskrun cancel | 2020/04/06-16:37
null | [Piyush Garg] Bump task describe command to v1beta1 | 2020/04/07-09:56
null | [Khurram Baig] Add Workspace to Interactive Start Pipeline | 2020/04/07-10:23
null | [Piyush Garg] Bump tektoncd/triggers to v0.4.0 | 2020/04/07-17:51
null | [Pradeep Kumar] fix tasrun cancel command | 2020/04/08-04:55
null | [Pradeep Kumar] v1beta1 support for pipelinerun cancel | 2020/04/08-11:42
null | [Daniel Helfand] properly capture APIVersion with --dry-run | 2020/04/08-14:35
null | [Pradeep Kumar] use List from task pkg | 2020/04/09-20:46
null | [Piyush Garg] Refactoring in make file | 2020/04/10-07:52
null | [Piyush Garg] Bump clustertask describe to v1beta1 | 2020/04/12-15:01
null | [Piyush Garg] Fix Makefile | 2020/04/12-15:01
null | [Daniel Helfand] sort taskruns by start time for task describe | 2020/04/12-15:50
null | [Daniel Helfand] sort taskruns by start time for clustertask describe | 2020/04/12-16:05
null | [Piyush Garg] Bump pipeline desc to v1beta1 | 2020/04/13-03:01
null | [Daniel Helfand] sort pipelineruns by start time for pipeline describe | 2020/04/13-14:32
null | [Piyush Garg] Bump pipelinerun describe to v1beta1 | 2020/04/14-07:13
null | [Daniel Helfand] update release process docs on updating plumbing tkn images | 2020/04/14-07:40
null | [Piyush Garg] Fix e2e on pipeline 0.10 | 2020/04/15-11:39
null | [Piyush Garg] Add test for task package | 2020/04/15-12:17
null | [Anshul Verma] Flag to start a Pipeline without prompting for default param value. Even when a param is given through -p, other params to have their default values. | 2020/04/15-14:25
null | [Piyush Garg] Fix lint error and handle properly | 2020/04/15-17:07
null | [Piyush Garg] Fix listing of taskrun | 2020/04/16-07:01
null | [Daniel Helfand] remove default timeout of 1h for pipeline and task start | 2020/04/16-07:48
null | [Chmouel Boudjnah] Use real temporary directory when building debian package | 2020/04/16-10:15
null | [Chmouel Boudjnah] Set properly the release version in Debian package | 2020/04/16-10:15
null | [Nidhi Kakkar] Modified param flag  description | 2020/04/16-15:48
null | [Carlos Iriarte] chore: fix typo inavlid => invalid | 2020/04/17-07:34
null | [Piyush Garg] Bump tektoncd/pipeline to v0.11.2 | 2020/04/17-08:10
null | [Piyush Garg] Bump taskrun describe to v1beta1 | 2020/04/17-09:01
null | [Vibhav Bobade] Sort TaskRuns based on StartTime before deletion with keep | 2020/04/17-11:49
null | [Vibhav Bobade] Add --no-headers and --all-namespaces flag for Task `list` subcommand | 2020/04/17-20:00
null | [Vibhav Bobade] Add --no-headers and --all-namespaces flag for Pipeline `list` | 2020/04/17-20:00
null | [Vibhav Bobade] Docs --no-headers --all-namespaces flags for task/pipeline list | 2020/04/17-20:00
null | [Pradeep Kumar] v1beta1 support for task start command | 2020/04/20-12:49
null | [Pradeep Kumar] adds test for v1beta1 | 2020/04/20-12:49
null | [Daniel Helfand] check status of taskrun for tkn pr describe | 2020/04/20-15:05
null | [Anshul Verma] Corrects `logs` command to validate `--limit` option's value if it is <=0 Resolves #909 | 2020/04/20-15:29
null | [Chmouel Boudjnah] Disable colouring on windows | 2020/04/21-10:59
null | [savitaashture] Add tkn triggerbinding describe command | 2020/04/21-14:53
null | [Daniel Helfand] fix keep description and remove need to use with --all flag | 2020/04/21-16:17
null | [savitaashture] fix aliases for clustertriggerbindings | 2020/04/21-20:07
null | [savitaashture] Add tkn clustertriggerbinding describe command | 2020/04/22-08:31
null | [Piyush Garg] Bump pipeline start to v1beta1 | 2020/04/22-08:51
null | [Pradeep Kumar] little refactor for consistency | 2020/04/22-12:53
null | [savitaashture] Add tkn triggertemplate describe command | 2020/04/22-15:55
null | [Daniel Helfand] fix alignment of output resource TYPE column for task desc | 2020/04/24-08:58
null | [Piyush Garg] Implement convertDown function for Taskrun | 2020/04/24-11:50
null | [savitaashture] Add params description to describe commands | 2020/04/24-12:52
null | [Pradeep Kumar] v1beta1 support for task start command | 2020/04/24-16:28
null | [Daniel Helfand] fix --dry-run with --filename tests for all start commands | 2020/04/27-07:24
null | [Piyush Garg] Bump tekton/pipeline to v0.11.3 | 2020/04/27-08:56
null | [Piyush Garg] Fix pipeline version not working | 2020/04/27-10:24
null | [Vincent Demeester] Build and publish tkn image on release 📌 | 2020/04/27-20:16
null | [Piyush Garg] Add description command for condition | 2020/04/28-03:37
null | [savitaashture] Add eventlistener describe command | 2020/04/28-06:10
null | [savitaashture] Update template for EventListener Describe command | 2020/04/28-10:46
null | [Anshul Verma] Enable auto selection of the task for `logs` command if only one task is present. Fixes #916 | 2020/04/28-12:27
null | [Daniel Helfand] fix description typo and add test with output option for el desc | 2020/04/28-13:48
null | [Piyush Garg] Remove namespace flag from clusterwide cmd's | 2020/04/28-15:02
null | [Piyush Garg] Add flag to skip check flag in version cmd | 2020/04/29-06:56

Signed-off-by: Piyush Garg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants