Use text/template Instead of html/template for PipelineRun Describe #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/S
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm
😅
…On Thu, 5 Mar 2020, 21:09 Daniel Helfand, ***@***.***> wrote:
Closes #776 <#776>
We should be using text/template not html/template to avoid html showing
up in describe commands. An example of this issue is actually showing up in
one of our tests, which I have changed backed to text.
We should also update all other describe commands, but I think that should
be done in a separate pull request to isolate issues that may come up.
- Includes tests
<https://github.com/tektoncd/community/blob/master/standards.md#principles>
(if functionality changed/added)
- Run the code checkers with make check
- Regenerate the manpages, docs and go formatting with make generated
- Commit messages follow commit message best practices
<https://github.com/tektoncd/community/blob/master/standards.md#commit-messages>
Release Notes
Correct message output for tkn pipelinerun describe
------------------------------
You can view, comment on, or merge this pull request online at:
#780
Commit Summary
- use text/template instead of html/template for pipelinerun describe
File Changes
- *M*
pkg/cmd/pipelinerun/testdata/TestPipelineRunDescribe_cancelled_pipelinerun.golden
<https://github.com/tektoncd/cli/pull/780/files#diff-b226961fa63672805e99400d4e0923c2>
(2)
- *M* pkg/pipelinerun/description/description.go
<https://github.com/tektoncd/cli/pull/780/files#diff-0e4c632e39337cb949f4597f63fec76d>
(10)
Patch Links:
- https://github.com/tektoncd/cli/pull/780.patch
- https://github.com/tektoncd/cli/pull/780.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#780?email_source=notifications&email_token=AAAYFJA7HSUUREBCAEX77DTRGABFPA5CNFSM4LCRTNJKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IS4W3SA>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAYFJB5VM3A7L4KVKJRBDTRGABFPANCNFSM4LCRTNJA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #776
We should be using
text/templatenothtml/templateto avoid html codes showing up in describe commands. An example of this issue is actually showing up in one of our tests, which I have changed backed to text.make checkmake generatedRelease Notes