Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update deps - k8s deps are now v0.19.7 #1298

Merged
merged 1 commit into from
Feb 10, 2021
Merged

update deps - k8s deps are now v0.19.7 #1298

merged 1 commit into from
Feb 10, 2021

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Feb 5, 2021 •
edited
Loading

This is bumping tekton deps to the latest

We've dropped replace directives for k8s deps upstream (knative & tekton) so they shouldn't require manual updates anymore.

/kind cleanup

NONE

/hold - there's breaking changes in trigger so i'll wait for that to be resolved prior to bumping k8s deps

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 5, 2021
@tekton-robot
Copy link
Contributor

Hi @dprotaso. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 5, 2021
@vdemeester
Copy link
Member

/ok-to-test
/hold
Holding this for just after the release 0.16 of cli (which should happen early next week)

@tekton-robot tekton-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 5, 2021
@dprotaso
Copy link
Contributor Author

dprotaso commented Feb 5, 2021

sorry - a dependency changed the case of a folder - i'll push that

@dprotaso dprotaso force-pushed the master branch 2 times, most recently from 00af37b to b06474c Compare February 5, 2021 19:24
@dprotaso
Copy link
Contributor Author

dprotaso commented Feb 5, 2021 •
edited
Loading

I realize theres some deprecated properties the triggers api that have been removed.

I'll probably delay this PR given someone's already working on the bump #1295

I'll rebase with the k8s bump

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2021
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2021
@dprotaso
Copy link
Contributor Author

dprotaso commented Feb 9, 2021

This is ready for a look now that a CLI release has been cut

@vdemeester
Copy link
Member

/hold cancel
/approve
@dprotaso can you squash your commits ? 😛

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 9, 2021
@dprotaso
Copy link
Contributor Author

dprotaso commented Feb 9, 2021

@dprotaso can you squash your commits ? 😛

Sure. Is there a reason why you don't have prow squash commits (ie. change the prow config here)

@dprotaso
bump deps & k8s is now @ 0.19.7
92265f9 
- use tektons/pipeline fakecontext helper
- golden files updated
- fix ordering issues introduced with k8s
  client-go.ObjectTracker using a map instead of an array
- use replacement package (golang/x/term) to address deprecation
piyush-garg
piyush-garg approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@piyush-garg piyush-garg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2021
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [piyush-garg,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit bf3150c into tektoncd:master Feb 10, 2021
pradeepitm12 added a commit that referenced this pull request Mar 12, 2021
@pradeepitm12
New version v0.17.0
332e825 
#1301 | [Piyush Garg] Update readme for tkn 0.16.0 | 2021/02/09-13:39
#1298 | [Dave Protasowski] bump deps & k8s is now @ 0.19.7 | 2021/02/10-07:04
#1306 | [06kellyjac] Use tkn pipeline start instead of kubectl create | 2021/02/11-11:54
#1303 | [Chmouel Boudjnah] Fix crash with pipeline describe when using inline taskSpec | 2021/02/16-12:25
#1305 | [06kellyjac] Add nix/nixos install instructions | 2021/02/16-18:07
#1315 | [Yulia Gaponenko] Fix eventListener e2e test with new RBAC permissions | 2021/03/09-18:11
#1316 | [Vincent Demeester] Rename master branch to main 🧙 | 2021/03/10-14:55
#1316 | [Vincent Demeester] Fix plumbing "main" branch reference | 2021/03/10-14:55
#1316 | [Vincent Demeester] Temporarly disable TestClusterTaskInteractiveStartE2E | 2021/03/10-14:55
#1318 | [Nikhil Thomas] Fix Typos | 2021/03/11-09:32
null | [Vincent Demeester] Bump triggers and pipeline to latest releases 🥍 | 2021/03/11-12:55
null | [Pradeep Kumar] master -> main in release.sh | 2021/03/11-14:31
null | [Pradeep Kumar] fix release script | 2021/03/11-17:00
null | [Pradeep Kumar] correct path in release.sh | 2021/03/11-17:28
null | [Pradeep Kumar] increase golint timeout | 2021/03/12-05:45

Signed-off-by: Pradeep Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg approved these changes

@danielhelfand danielhelfand Awaiting requested review from danielhelfand

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

Assignees

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dprotaso @tekton-robot @vdemeester @piyush-garg