Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Typos 🧑‍💻 #1318

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Fix Typos 🧑‍💻 #1318

merged 1 commit into from
Mar 11, 2021

Conversation

nikhil-thomas
Copy link
Member

fix s/emtpy/empty/ in multiple locations 🤓

Signed-off-by: Nikhil Thomas [email protected]

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

@nikhil-thomas
Fix Typos
7112c07 
fix `s/emtpy/empty/` in multiple locations 🤓

Signed-off-by: Nikhil Thomas <[email protected]>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 10, 2021
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 10, 2021
pradeepitm12
pradeepitm12 approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 10, 2021
piyush-garg
piyush-garg approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@piyush-garg piyush-garg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, pradeepitm12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [piyush-garg,pradeepitm12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chmouel
Copy link
Member

chmouel commented Mar 10, 2021

/lgtm

Looking Good! 🤙🏽

@vdemeester
Copy link
Member

/retest

3 similar comments
@nikhil-thomas
Copy link
Member Author

/retest

@piyush-garg
Copy link
Contributor

/retest

@chmouel
Copy link
Member

chmouel commented Mar 11, 2021

/retest

@tekton-robot tekton-robot merged commit 74875c0 into tektoncd:main Mar 11, 2021
pradeepitm12 added a commit that referenced this pull request Mar 12, 2021
@pradeepitm12
New version v0.17.0
332e825 
#1301 | [Piyush Garg] Update readme for tkn 0.16.0 | 2021/02/09-13:39
#1298 | [Dave Protasowski] bump deps & k8s is now @ 0.19.7 | 2021/02/10-07:04
#1306 | [06kellyjac] Use tkn pipeline start instead of kubectl create | 2021/02/11-11:54
#1303 | [Chmouel Boudjnah] Fix crash with pipeline describe when using inline taskSpec | 2021/02/16-12:25
#1305 | [06kellyjac] Add nix/nixos install instructions | 2021/02/16-18:07
#1315 | [Yulia Gaponenko] Fix eventListener e2e test with new RBAC permissions | 2021/03/09-18:11
#1316 | [Vincent Demeester] Rename master branch to main 🧙 | 2021/03/10-14:55
#1316 | [Vincent Demeester] Fix plumbing "main" branch reference | 2021/03/10-14:55
#1316 | [Vincent Demeester] Temporarly disable TestClusterTaskInteractiveStartE2E | 2021/03/10-14:55
#1318 | [Nikhil Thomas] Fix Typos | 2021/03/11-09:32
null | [Vincent Demeester] Bump triggers and pipeline to latest releases 🥍 | 2021/03/11-12:55
null | [Pradeep Kumar] master -> main in release.sh | 2021/03/11-14:31
null | [Pradeep Kumar] fix release script | 2021/03/11-17:00
null | [Pradeep Kumar] correct path in release.sh | 2021/03/11-17:28
null | [Pradeep Kumar] increase golint timeout | 2021/03/12-05:45

Signed-off-by: Pradeep Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradeepitm12 pradeepitm12 pradeepitm12 approved these changes

@piyush-garg piyush-garg piyush-garg approved these changes

@danielhelfand danielhelfand Awaiting requested review from danielhelfand

Assignees

@chmouel chmouel

@piyush-garg piyush-garg

@pradeepitm12 pradeepitm12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nikhil-thomas @tekton-robot @chmouel @vdemeester @piyush-garg @pradeepitm12