Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Test Failure from go v1.14.0 Update #833

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Fix Test Failure from go v1.14.0 Update #833

merged 1 commit into from
Mar 26, 2020

Conversation

danielhelfand
Copy link
Member

@danielhelfand danielhelfand commented Mar 25, 2020 •
edited
Loading

Updating to go v1.14.0 breaks TestGetError in file/file_test.go. This pull request adds quotes around the invalid url for the error message.

Submitter Checklist

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

Release Notes

N/A

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2020
@tekton-robot tekton-robot requested review from hrishin and sthaha March 25, 2020 13:43
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 25, 2020
@danielhelfand danielhelfand changed the title WIP: Fix Test Failure from go v1.14.0 Update Fix Test Failure from go v1.14.0 Update Mar 25, 2020
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2020
@danielhelfand danielhelfand mentioned this pull request Mar 25, 2020
Merged
4 tasks
vdemeester
vdemeester reviewed Mar 25, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail on go 1.13 though right ? 🤔
(I wonder if we could do a fix that work on both 🙃)

pkg/file/file_test.go Outdated
@@ -61,5 +61,5 @@ func TestGetError(t *testing.T) {
target := "httpz://foo.com/task.yaml"

_, err := LoadFileContent(p, target, IsYamlFile(), fmt.Errorf("invalid file format for %s: .yaml or .yml file extension and format required", target))
assert.Error(t, err, `Get httpz://foo.com/task.yaml: unsupported protocol scheme "httpz"`)
assert.Error(t, err, "Get \"httpz://foo.com/task.yaml\": unsupported protocol scheme \"httpz\"")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: using allows us to not have to *escape*"`

@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2020
@danielhelfand
Copy link
Member Author

This will fail on go 1.13 though right ? 🤔
(I wonder if we could do a fix that work on both 🙃)

We could parse the runtime go version and support both error output formats, but it's not pretty. I pushed up something for this to try.

@vdemeester
Copy link
Member

We could parse the runtime go version and support both error output formats, but it's not pretty. I pushed up something for this to try.

Yeah this is ugly 😛 I was more thinking of trying to use string.Contains with unsupported protocol scheme and maybe the url 😝

@vdemeester
Copy link
Member

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2020
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2020
@danielhelfand
Copy link
Member Author

We could parse the runtime go version and support both error output formats, but it's not pretty. I pushed up something for this to try.

Yeah this is ugly 😛 I was more thinking of trying to use string.Contains with unsupported protocol scheme and maybe the url 😝

Yeah, I over thought it. Changed to checking with strings.Contains.

vdemeester
vdemeester approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@vdemeester
Copy link
Member

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2020
@tekton-robot tekton-robot merged commit a8c36e2 into tektoncd:master Mar 26, 2020
@danielhelfand danielhelfand mentioned this pull request Apr 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@hrishin hrishin Awaiting requested review from hrishin

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielhelfand @vdemeester @tekton-robot @googlebot