v1beta1 support for pipeline list cmd #832
Conversation
tekton-robot
added
the
size/L
|
The following is the coverage report on pkg/.
|
|
/test pull-tekton-cli-unit-tests |
|
/retest |
|
I'm wondering if tektoncd/pipeline#2186 is related to this failure? The errors look very similar to when we tried to release using the go test Task from the catalog that had been updated to v1.14. cc @vdemeester Edit: More specifically tektoncd/plumbing#279? |
|
Opened #833, which should resolve the unit test issue. Seems to be more of an issue with format of the error from the http client. |
|
The following is the coverage report on pkg/.
|
|
/test pull-tekton-cli-unit-tests I think the test in question is flaky.
|
|
@danielhelfand Thanks for the quick bug fix and 👍 |
pkg/pipeline/pipeline.go
Outdated
| func List(c *cli.Clients, opts metav1.ListOptions, ns string) (*v1beta1.PipelineList, error) { | ||
|
|
||
| pipelineGroupResource := schema.GroupVersionResource{Group: "tekton.dev", Resource: "pipelines"} | ||
| unstructuredTR, err := plist.AllObjecs(pipelineGroupResource, c, ns, opts) |
There was a problem hiding this comment.
Any reason for calling this unstructuredTR? Maybe change to P or Ps for pipelines?
There was a problem hiding this comment.
Good catch it's my bad, copy-paste err
this adds v1beta1 support for pipeline list command minor refactor to taskrun list Signed-off-by: Pradeep Kumar [email protected]
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
approved
|
The following is the coverage report on pkg/.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielhelfand, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this adds v1beta1 support for pipeline list command
minor refactor to taskrun list
Signed-off-by: Pradeep Kumar [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes