v1beta1 support for taskrun delete #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/L
|
/hold |
tekton-robot
added
the
do-not-merge/hold
this adds v1beta1 support for taskrun delete cammand also puts list and delete in `actions/list` `actions/delete` so that upcoming actions like `create`, `get` etc can be addes to actions may get some refactors in upcoming pr's Signed-off-by: Pradeep Kumar [email protected]
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
|
/test pull-tekton-cli-unit-tests |
vdemeester
approved these changes
Mar 27, 2020
| "k8s.io/client-go/restmapper" | ||
| ) | ||
|
|
||
| func GetGVR(gr schema.GroupVersionResource, discovery discovery.DiscoveryInterface) (*schema.GroupVersionResource, error) { |
There was a problem hiding this comment.
Shouldn't we use the full name ? GetGroupVersionResource ? because I thing GetGVR, I have no idea what is it about 😅
There was a problem hiding this comment.
Sure, will update it in coming pr
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds v1beta1 support for taskrun delete cammand
also puts list and delete in
actions/listactions/deletesothat upcoming actions like
create,getetc can be addes toactions
may get some refactors in upcoming pr's
Signed-off-by: Pradeep Kumar [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes