-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config map names should be customizable, or at least prefixable #1805
Comments
Looks like the prefix idea would be a challenge for |
I think we'd be open to this if anyone wants to do the work! |
/assign @jerop |
@dibyom: GitHub didn't allow me to assign the following users: jerop. Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The config maps used by Tekton Pipeline should be able to take custom names to avoid collisions with other services. However, the feature-flags config map wasn't customizable because its name hardcoded its usages. By defining an env var in controller.yaml, from which the feature-flags config map name can be derived, we enable it to be customizable. Fixes tektoncd#1805.
The config maps used by Tekton Pipeline should be able to take custom names to avoid collisions with other services. However, the feature-flags config map wasn't customizable because its name hardcoded its usages. By defining an env var in controller.yaml, from which the feature-flags config map name can be derived, we enable it to be customizable. Fixes tektoncd#1805.
The config maps used by Tekton Pipeline should be able to take custom names to avoid collisions with other services. However, the feature-flags config map wasn't customizable because its name hardcoded its usages. By defining an env var in controller.yaml, from which the feature-flags config map name can be derived, we enable it to be customizable. Fixes #1805.
Expected Behavior
The various config maps used by Tekton Pipeline (
config-artifact-bucket
,config-logging
, etc) should be able to be given custom names, to avoid potential collisions with other services.Actual Behavior
They can't. =)
Steps to Reproduce the Problem
name
of one of the config maps.Additional Info
For the standard usage, this isn't a problem, since the config maps go into the
tekton-pipelines
namespace, but in Jenkins X, we put everything in thejx
namespace along with...lots of other junk. It'd be really handy if we could at the least prefix the config map names to guarantee uniqueness. I haven't thought through the implementation details, but maybe something like an optional argument to thecontroller
andwebhook
to provide a prefix for the various config map names would work.The text was updated successfully, but these errors were encountered: