Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config map names should be customizable, or at least prefixable #1805

Closed
abayer opened this issue Jan 5, 2020 · 5 comments · Fixed by #2363
Closed

Config map names should be customizable, or at least prefixable #1805

abayer opened this issue Jan 5, 2020 · 5 comments · Fixed by #2363
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@abayer
Copy link
Contributor

abayer commented Jan 5, 2020

Expected Behavior

The various config maps used by Tekton Pipeline (config-artifact-bucket, config-logging, etc) should be able to be given custom names, to avoid potential collisions with other services.

Actual Behavior

They can't. =)

Steps to Reproduce the Problem

  1. Change the name of one of the config maps.
  2. Anything referring to that config map won't work.

Additional Info

For the standard usage, this isn't a problem, since the config maps go into the tekton-pipelines namespace, but in Jenkins X, we put everything in the jx namespace along with...lots of other junk. It'd be really handy if we could at the least prefix the config map names to guarantee uniqueness. I haven't thought through the implementation details, but maybe something like an optional argument to the controller and webhook to provide a prefix for the various config map names would work.

@abayer abayer added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 5, 2020
@abayer
Copy link
Contributor Author

abayer commented Jan 5, 2020

Looks like the prefix idea would be a challenge for config-observability since that config map is only referenced from knative.dev/pkg code...

@bobcatfish
Copy link
Collaborator

I think we'd be open to this if anyone wants to do the work!

@dibyom
Copy link
Member

dibyom commented Apr 9, 2020

/assign @jerop

@tekton-robot
Copy link
Collaborator

@dibyom: GitHub didn't allow me to assign the following users: jerop.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @jerop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerop pushed a commit to jerop/pipeline that referenced this issue Apr 9, 2020
The config maps used by Tekton Pipeline should be able to take custom
names to avoid collisions with other services.

However, the feature-flags config map wasn't customizable because its
name hardcoded its usages.

By defining an env var in controller.yaml, from which the feature-flags
config map name can be derived, we enable it to be customizable.

Fixes tektoncd#1805.
@jerop
Copy link
Member

jerop commented Apr 9, 2020

@dibyom and I looked into this, and found that all config maps are customizable except for feature-flags config map which is fixed in #2363

the other config maps had be fixed in #1723

jerop added a commit to jerop/pipeline that referenced this issue Apr 9, 2020
The config maps used by Tekton Pipeline should be able to take custom
names to avoid collisions with other services.

However, the feature-flags config map wasn't customizable because its
name hardcoded its usages.

By defining an env var in controller.yaml, from which the feature-flags
config map name can be derived, we enable it to be customizable.

Fixes tektoncd#1805.
tekton-robot pushed a commit that referenced this issue Apr 10, 2020
The config maps used by Tekton Pipeline should be able to take custom
names to avoid collisions with other services.

However, the feature-flags config map wasn't customizable because its
name hardcoded its usages.

By defining an env var in controller.yaml, from which the feature-flags
config map name can be derived, we enable it to be customizable.

Fixes #1805.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants