Don't hard-code names of configmaps used for artifact persistence #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tekton-robot
added
the
size/L
|
/test pull-tekton-pipeline-build-tests |
vdemeester
requested changes
Dec 10, 2019
test/wait.go
Outdated
| @@ -167,7 +167,7 @@ func TaskRunSucceed(name string) TaskRunStateFn { | |||
| if c.Status == corev1.ConditionTrue { | |||
| return true, nil | |||
| } else if c.Status == corev1.ConditionFalse { | |||
| return true, fmt.Errorf("task run %q failed!", name) | |||
| return true, fmt.Errorf("TaskRun %q failed!", name) | |||
There was a problem hiding this comment.
Ah I should have read the error message 😆
This allows users to rename the config maps so long as they also update the env var value specified in controller.yaml
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
Apr 13, 2020
Add docs on how users can customize names for configmaps used for artifact persistence. The relevant changes were implemented in tektoncd#1723 and tektoncd#2363.
3 tasks
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
Apr 13, 2020
Add docs on how users can customize names for configmaps used for artifact persistence. The relevant changes were implemented in tektoncd#1723 and tektoncd#2363. Update the link to pipeline instead of forked Had mistakenly linked to controller.yaml in forked repo, corrected to link to the tektoncd/pipeline repo Add docs on customizing configmaps Add docs on how users can customize names for configmaps used for artifact persistence. The relevant changes were implemented in tektoncd#1723 and tektoncd#2363.
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
Apr 13, 2020
Add docs on how users can customize names for configmaps used for artifact persistence. The relevant changes were implemented in tektoncd#1723 and tektoncd#2363.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to rename the config maps so long as they also update
the env var value specified in controller.yaml
Progress toward #1713
cc @silverlyra
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes