Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start using YAMLParsers in /test/*_test.go #4276

Closed
pritidesai opened this issue Oct 5, 2021 · 0 comments · Fixed by #4288
Closed

start using YAMLParsers in /test/*_test.go #4276

pritidesai opened this issue Oct 5, 2021 · 0 comments · Fixed by #4288
Assignees
@abayer
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@pritidesai
Copy link
Member

@imjasonh added YAML helpers in https://github.com/tektoncd/pipeline/blob/main/test/yaml.go which takes a YAML in a string and returns respective desearlized objects including:

  • Task
  • TaskRun
  • Pipeline
  • PipelineRun

These helpers can help simplify the way we have implemented the integration tests. Most of the integration tests under /test initialize objects directly or have implemented functions to create such objects. The integration tests also serves as a great reference after /examples for the users to learn how to implement task/pipeline specifications. It will be beneficial to our users and contributors, if we can simplify the tests i.e instead of initializing these objects, add YAML specifications in the tests.

A huge thank you to @abayer for undertaking this cleanup 🙏

/kind cleanup
@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 5, 2021
abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Oct 6, 2021
@abayer
Convert test/cluster_resource_test.go's Tekton structs to YAML
7663f76 
Part of tektoncd#4276

Signed-off-by: Andrew Bayer <[email protected]>
@abayer abayer mentioned this issue Oct 6, 2021
Merged
5 tasks
tekton-robot pushed a commit that referenced this issue Oct 7, 2021
@abayer @tekton-robot
Convert test/cluster_resource_test.go's Tekton structs to YAML
ce098f8 
Part of #4276

Signed-off-by: Andrew Bayer <[email protected]>
abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Oct 7, 2021
@abayer
Switch test/*.go to using YAML rather than structs
31ea5cc 
Part of tektoncd#4276

Note that `test/pipelinefinally_test.go` is largely not converted to YAML,
because it relies heavily on parameterized generation of `Task`s and`Pipeline`s,
to the point where it would be far more complicated to switch to YAML than to
leave it as is.

Also, `test/v1alpha1` still needs to be done.

Signed-off-by: Andrew Bayer <[email protected]>
@abayer abayer mentioned this issue Oct 7, 2021
Merged
5 tasks
abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Oct 7, 2021
@abayer
Switch test/*.go to using YAML rather than structs
fe002dd 
Part of tektoncd#4276

Note that `test/pipelinefinally_test.go` is largely not converted to YAML,
because it relies heavily on parameterized generation of `Task`s and`Pipeline`s,
to the point where it would be far more complicated to switch to YAML than to
leave it as is.

Also, `test/v1alpha1` still needs to be done.

Signed-off-by: Andrew Bayer <[email protected]>
abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Oct 7, 2021
@abayer
Switch test/*.go to using YAML rather than structs
0ed21eb 
Part of tektoncd#4276

Note that `test/pipelinefinally_test.go` is largely not converted to YAML,
because it relies heavily on parameterized generation of `Task`s and`Pipeline`s,
to the point where it would be far more complicated to switch to YAML than to
leave it as is.

Also, `test/v1alpha1` still needs to be done.

Signed-off-by: Andrew Bayer <[email protected]>
abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Oct 7, 2021
@abayer
Switch test/*.go to using YAML rather than structs
1794f47 
Part of tektoncd#4276

Note that `test/pipelinefinally_test.go` is largely not converted to YAML,
because it relies heavily on parameterized generation of `Task`s and`Pipeline`s,
to the point where it would be far more complicated to switch to YAML than to
leave it as is.

Also, `test/v1alpha1` still needs to be done.

Signed-off-by: Andrew Bayer <[email protected]>
abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Oct 8, 2021
@abayer
Switch test/*.go to using YAML rather than structs
50ae2b8 
Part of tektoncd#4276

Note that `test/pipelinefinally_test.go` is largely not converted to YAML,
because it relies heavily on parameterized generation of `Task`s and`Pipeline`s,
to the point where it would be far more complicated to switch to YAML than to
leave it as is.

Also, `test/v1alpha1` still needs to be done.

Signed-off-by: Andrew Bayer <[email protected]>
abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Oct 8, 2021
@abayer
Switch test/*.go to using YAML rather than structs
5de4265 
Part of tektoncd#4276

`test/v1alpha1` still needs to be done.

Signed-off-by: Andrew Bayer <[email protected]>
abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Oct 8, 2021
@abayer
Switch test/*.go to using YAML rather than structs
527a273 
fixes tektoncd#4276

Signed-off-by: Andrew Bayer <[email protected]>
abayer added a commit to abayer/tektoncd-pipeline that referenced this issue Oct 12, 2021
@abayer
Switch test/*.go to using YAML rather than structs
507058f 
fixes tektoncd#4276

Signed-off-by: Andrew Bayer <[email protected]>
tekton-robot pushed a commit that referenced this issue Oct 12, 2021
@abayer @tekton-robot
Switch test/*.go to using YAML rather than structs
38b9f26 
fixes #4276

Signed-off-by: Andrew Bayer <[email protected]>
chenbh pushed a commit to chenbh/pipeline that referenced this issue Oct 27, 2021
@abayer @chenbh
Convert test/cluster_resource_test.go's Tekton structs to YAML
82c9322 
Part of tektoncd#4276

Signed-off-by: Andrew Bayer <[email protected]>
chenbh pushed a commit to chenbh/pipeline that referenced this issue Oct 27, 2021
@abayer @chenbh
Switch test/*.go to using YAML rather than structs
0fcd954 
fixes tektoncd#4276

Signed-off-by: Andrew Bayer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abayer abayer

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch test/*.go to using YAML rather than structs abayer/tektoncd-pipeline
3 participants
@abayer @pritidesai @tekton-robot