-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert test/cluster_resource_test.go's Tekton structs to YAML #4284
Convert test/cluster_resource_test.go's Tekton structs to YAML #4284
Conversation
Part of tektoncd#4276 Signed-off-by: Andrew Bayer <[email protected]>
/wip |
fixes tektoncd#4284 Signed-off-by: Andrew Bayer <[email protected]>
1baea70
to
7663f76
Compare
fixes tektoncd#4284 Signed-off-by: Andrew Bayer <[email protected]>
#4286 fixes the flaky |
/test pull-tekton-pipeline-alpha-integration-tests |
This will be helpful in most of the tests since some of the artifacts including names are auto generated.
You decide 😄 I think we can if we have many occurrences of secrets and ConfigMaps. For now, this is great. /approve |
@pritidesai - ok! If I hit enough other |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
/lgtm
Changes
Part of #4276
This is just one file from
test/...
, but it seemed like a good "let's start here" case to make sure the approaches I've gone with are acceptable:fmt.Sprintf(...)
, since I decided that the raw multiline string literal was the way to go even if we need to do some%s
replacement in it.Secret
andConfigMap
used in this test I just leave as is, rather than changing them to YAML. If y'all feel we should move those too, well, I'll do that. =)/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes