Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Resources Package in PipelineRun Reconciler #5024

Closed
1 of 8 tasks
jerop opened this issue Jun 22, 2022 · 5 comments
Closed
1 of 8 tasks

Refactor Resources Package in PipelineRun Reconciler #5024

jerop opened this issue Jun 22, 2022 · 5 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@jerop
Copy link
Member

jerop commented Jun 22, 2022

The resources package in PipelineRun reconciler is doing too much and needs some cleanup: https://github.com/tektoncd/pipeline/tree/v0.37.0/pkg/reconciler/pipelinerun/resources

Here are some cleanup ideas @pritidesai and I put together:

  • ResolvedPipelineRunTask to ResolvedPipelineTask #5025
  • Create validation package
  • Create apply package
  • Create state package (PipelineRunState)
  • Create facts package (PipelineRunFacts)
  • Create status package
  • Create resolution package (ResolvedPipelineTask)
  • Create pipeline package (GetPipelineFunc + GetPipelineData)

We'd appreciate suggestions and contributions to making the codebase cleaner.

/assign
/assign @pritidesai
cc @dibyom @JeromeJu

@jerop jerop added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 22, 2022
jerop added a commit to jerop/pipeline that referenced this issue Jun 22, 2022
`ResolvedPipelineRunTask` is a confusing name for a `PipelineTask`
and its resources, plus we don't have a `PipelineRunTask` object.

This change renames `ResolvedPipelineRunTask` to `ResolvedPipelineTask`.

Issue: tektoncd#5024
jerop added a commit to jerop/pipeline that referenced this issue Jun 22, 2022
`ResolvedPipelineRunTask` is a confusing name for a `PipelineTask`
and its resources, plus we don't have a `PipelineRunTask` object.

This change renames `ResolvedPipelineRunTask` to `ResolvedPipelineTask`.

Issue: tektoncd#5024
jerop added a commit to jerop/pipeline that referenced this issue Jun 22, 2022
`ResolvedPipelineRunTask` is a confusing name for a `PipelineTask`
and its resources, plus we don't have a `PipelineRunTask` object.

This change renames `ResolvedPipelineRunTask` to `ResolvedPipelineTask`.

Issue: tektoncd#5024
tekton-robot pushed a commit that referenced this issue Jun 23, 2022
`ResolvedPipelineRunTask` is a confusing name for a `PipelineTask`
and its resources, plus we don't have a `PipelineRunTask` object.

This change renames `ResolvedPipelineRunTask` to `ResolvedPipelineTask`.

Issue: #5024
@JeromeJu
Copy link
Member

JeromeJu commented Jul 4, 2022

/assign

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 2, 2022
@tekton-robot
Copy link
Collaborator

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 1, 2022
@tekton-robot
Copy link
Collaborator

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Collaborator

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Repository owner moved this from Todo to Done in Tekton Community Roadmap Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
Status: Done
Development

No branches or pull requests

4 participants