-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Resources Package in PipelineRun Reconciler #5024
Comments
`ResolvedPipelineRunTask` is a confusing name for a `PipelineTask` and its resources, plus we don't have a `PipelineRunTask` object. This change renames `ResolvedPipelineRunTask` to `ResolvedPipelineTask`. Issue: tektoncd#5024
`ResolvedPipelineRunTask` is a confusing name for a `PipelineTask` and its resources, plus we don't have a `PipelineRunTask` object. This change renames `ResolvedPipelineRunTask` to `ResolvedPipelineTask`. Issue: tektoncd#5024
`ResolvedPipelineRunTask` is a confusing name for a `PipelineTask` and its resources, plus we don't have a `PipelineRunTask` object. This change renames `ResolvedPipelineRunTask` to `ResolvedPipelineTask`. Issue: tektoncd#5024
`ResolvedPipelineRunTask` is a confusing name for a `PipelineTask` and its resources, plus we don't have a `PipelineRunTask` object. This change renames `ResolvedPipelineRunTask` to `ResolvedPipelineTask`. Issue: #5024
/assign |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The resources package in PipelineRun reconciler is doing too much and needs some cleanup: https://github.com/tektoncd/pipeline/tree/v0.37.0/pkg/reconciler/pipelinerun/resources
Here are some cleanup ideas @pritidesai and I put together:
ResolvedPipelineRunTask
toResolvedPipelineTask
#5025We'd appreciate suggestions and contributions to making the codebase cleaner.
/assign
/assign @pritidesai
cc @dibyom @JeromeJu
The text was updated successfully, but these errors were encountered: