ResolvedPipelineRunTask to ResolvedPipelineTask
#5025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/XL
8 tasks
|
The following is the coverage report on the affected files.
|
|
why did the rename decrease the coverage for resultresolution.go? 🤔 |
abayer
reviewed
Jun 22, 2022
tekton-robot
added
the
do-not-merge/hold
jerop
force-pushed
the
resolvedpipelinetask
branch
from
619039d to
db07cae
Compare
tekton-robot
removed
the
do-not-merge/hold
`ResolvedPipelineRunTask` is a confusing name for a `PipelineTask` and its resources, plus we don't have a `PipelineRunTask` object. This change renames `ResolvedPipelineRunTask` to `ResolvedPipelineTask`. Issue: tektoncd#5024
jerop
force-pushed
the
resolvedpipelinetask
branch
from
db07cae to
646f3b0
Compare
|
/lgtm |
vdemeester
approved these changes
Jun 23, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
Jun 23, 2022
In tektoncd#5025, we renamed ResolvedPipelineRunTask to ResolvedPipelineTask. In this change, we rename the function that creates it to align with the new type name.
3 tasks
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
Jun 23, 2022
In tektoncd#5025, we renamed ResolvedPipelineRunTask to ResolvedPipelineTask. In this change, we rename the function that creates it to align with the new type name.
tekton-robot
pushed a commit
that referenced
this pull request
Jun 23, 2022
In #5025, we renamed ResolvedPipelineRunTask to ResolvedPipelineTask. In this change, we rename the function that creates it to align with the new type name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ResolvedPipelineRunTaskis a confusing name for aPipelineTaskand its resources, plus we don't have a
PipelineRunTaskobject.This change renames
ResolvedPipelineRunTasktoResolvedPipelineTask.Issue: #5024
/kind cleanup
cc @pritidesai
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Release Notes