Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Release Notes section of our PR checklist #5093

Closed
dibyom opened this issue Jul 6, 2022 · 0 comments · Fixed by #5094
Closed

Simplify Release Notes section of our PR checklist #5093

dibyom opened this issue Jul 6, 2022 · 0 comments · Fixed by #5094
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one.

Comments

@dibyom
Copy link
Member

dibyom commented Jul 6, 2022

I find the release notes section of our PR checklist to be confusing - it's long, contains a lot of instructions, the back-ticks have to be followed by the literal string "release-note", the templates within the comment have to be copied outside the comment block, multiple ways of adding the NONE release note etc. In the last two weeks, I have manually fixed the section of at least 3 PRs while reviewing them.
I think we can do better and simplify the experience for most scenarios by:

  1. Adding a default NONE release note
  2. Update the existing submitter checklist to let the the PR author know they are expected to update the release note section if necessary
  3. Add a new item to the checklist to add the action required string (if needed) as well as the kind label.
@dibyom dibyom added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 6, 2022
dibyom added a commit to dibyom/pipeline that referenced this issue Jul 6, 2022
This commit simplifies the release notes section by replacing the existing
comment with a default `NONE` release note. In addition it updates the
submitter checklist instruction to expect the submitter to update the release
note if needed. In addition, it adds two new items to the checklist - 1. to add
a kind label using the /kind command and 2. add an `action required:` to the
release note if needed.

Fixes tektoncd#5093

Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom added a commit to dibyom/pipeline that referenced this issue Jul 6, 2022
This commit simplifies the release notes section by replacing the existing
comment with a default `NONE` release note. In addition it updates the
submitter checklist instruction to expect the submitter to update the release
note if needed. In addition, it adds two new items to the checklist - 1. to add
a kind label using the /kind command and 2. add an `action required:` to the
release note if needed.

Fixes tektoncd#5093

Signed-off-by: Dibyo Mukherjee <[email protected]>
tekton-robot pushed a commit that referenced this issue Jul 7, 2022
This commit simplifies the release notes section by replacing the existing
comment with a default `NONE` release note. In addition it updates the
submitter checklist instruction to expect the submitter to update the release
note if needed. In addition, it adds two new items to the checklist - 1. to add
a kind label using the /kind command and 2. add an `action required:` to the
release note if needed.

Fixes #5093

Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom added a commit that referenced this issue Jul 7, 2022
There was an added space between the backticks and the release-note string
See #5093
@dibyom dibyom mentioned this issue Jul 7, 2022
7 tasks
dibyom added a commit that referenced this issue Jul 19, 2022
There was an added space between the backticks and the release-note string
See #5093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant