Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release-note formatting #5105

Closed
wants to merge 1 commit into from
Closed

Fix release-note formatting #5105

wants to merge 1 commit into from

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Jul 7, 2022

Changes

There was an added space between the backticks and the release-note string
See #5093

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jul 7, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from dibyom after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2022
@tekton-robot tekton-robot requested review from imjasonh and jerop July 7, 2022 20:10
@dibyom
Copy link
Member Author

dibyom commented Jul 7, 2022

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 7, 2022
@abayer
Copy link
Contributor

abayer commented Jul 8, 2022

This was a deliberate move by @vdemeester to make sure the release note checker wouldn’t pass if someone just didn’t change anything in the release note section.

@afrittoli
Copy link
Member

This was a deliberate move by @vdemeester to make sure the release note checker wouldn’t pass if someone just didn’t change anything in the release note section.

The alternative could be to have this job running against pipeline https://dashboard.dogfooding.tekton.dev/#/namespaces/tekton-ci/pipelineruns/check-github-tasks-completed-dxg7f?pipelineTask=github-tasks-completed

@dibyom
Copy link
Member Author

dibyom commented Jul 12, 2022

This was a deliberate move by @vdemeester to make sure the release note checker wouldn’t pass if someone just didn’t change anything in the release note section.

Yes, the release checker doesn't pass but I've found that as a reviewer I still have to point out removing the space (or just do it myself). We already mention filling out the release notes in the Submitter checklist and I was hoping that would be enough? (The automated check also sounds good).

There was an added space between the backticks and the release-note string
See #5093
@tekton-robot
Copy link
Collaborator

@dibyom: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-pipeline-unit-tests a450e05 link true /test tekton-pipeline-unit-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@afrittoli
Copy link
Member

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@afrittoli: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Member

/test pull-tekton-pipeline-unit-tests

@tekton-robot
Copy link
Collaborator

@afrittoli: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-unit-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dibyom
Copy link
Member Author

dibyom commented Jul 19, 2022

See #5171 for the flaky unit test fix

@vdemeester
Copy link
Member

🤔 maybe we should not even have the release-note part in the template then 🤔

@abayer abayer mentioned this pull request Aug 11, 2022
7 tasks
@jerop
Copy link
Member

jerop commented Sep 27, 2022

#5308

@jerop jerop closed this Sep 27, 2022
@dibyom dibyom deleted the dibyom-patch-2 branch September 27, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants