-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix release-note formatting #5105
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind misc |
This was a deliberate move by @vdemeester to make sure the release note checker wouldn’t pass if someone just didn’t change anything in the release note section. |
The alternative could be to have this job running against pipeline https://dashboard.dogfooding.tekton.dev/#/namespaces/tekton-ci/pipelineruns/check-github-tasks-completed-dxg7f?pipelineTask=github-tasks-completed |
Yes, the release checker doesn't pass but I've found that as a reviewer I still have to point out removing the space (or just do it myself). We already mention filling out the release notes in the Submitter checklist and I was hoping that would be enough? (The automated check also sounds good). |
There was an added space between the backticks and the release-note string See #5093
@dibyom: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test check-pr-has-kind-label |
@afrittoli: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-tekton-pipeline-unit-tests |
@afrittoli: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
See #5171 for the flaky unit test fix |
🤔 maybe we should not even have the |
Changes
There was an added space between the backticks and the release-note string
See #5093
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes