Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0114: Custom Tasks Beta - Support v1beta1.CustomRun #5153

Closed
Tracked by #4313
jerop opened this issue Jul 18, 2022 · 5 comments
Closed
Tracked by #4313

TEP-0114: Custom Tasks Beta - Support v1beta1.CustomRun #5153

jerop opened this issue Jul 18, 2022 · 5 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jerop
Copy link
Member

jerop commented Jul 18, 2022

In TEP-0114: Custom Tasks Beta, we proposed migrating Custom Tasks and Runs to beta.

Moving v1alpha1.Run to v1beta1.CustomRun is a required API change in TEP-0114: Custom Tasks Beta. This issue tracks this API change.

@jerop jerop added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 18, 2022
@lbernick lbernick moved this to Todo in Pipelines V1 Jul 26, 2022
@vsinghai
Copy link

vsinghai commented Sep 6, 2022

/assign

vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 12, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 14, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 19, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 20, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 20, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 21, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 21, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
@lbernick lbernick moved this from Todo to In Progress in Pipelines V1 Sep 22, 2022
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 22, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 22, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 22, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 22, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 26, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 27, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
@jerop jerop added this to the Pipelines v0.42 milestone Oct 6, 2022
@XinruZhang
Copy link
Member

Putting a note here as a reminder: all the references about v1alpha1.Run should be migrated to v1beta1.CustomRun, for example:

const (
// RunCancelledByPipelineMsg indicates that the PipelineRun of which part this Run was
// has been cancelled.
RunCancelledByPipelineMsg RunSpecStatusMessage = "Run cancelled as the PipelineRun it belongs to has been cancelled."
// RunCancelledByPipelineTimeoutMsg indicates that the Run was cancelled because the PipelineRun running it timed out.
RunCancelledByPipelineTimeoutMsg RunSpecStatusMessage = "Run cancelled as the PipelineRun it belongs to has timed out."
)

Thanks for @lbernick 's input!

@pritidesai
Copy link
Member

Pipeline WG - Blockers:

  • What should go in RunSpec?
  • How to support v1alpha1 Run along with v1beta1 CustomRun?

/cc @ScrapCodes

@vdemeester
Copy link
Member

On the second question, I would ask a question to the question : do we even want to support both ? v1alpha1.Run is alpha, we can pretty much do whatever. As already mentionned during a WG, if we give a timeline when tektoncd/pipeline will start creating v1beta1.CustomRun instead of v1alpha1.Run, announce it, it should give enough time for current CustomTask project to update to handle v1beta1.CustomRun (in addition to v1alpha1.Run or not — but that's on those project, not tektoncd/pipeline to support both APIs, or not).

@dibyom dibyom removed this from the Pipelines v0.42 milestone Nov 29, 2022
@dibyom dibyom added this to the Pipelines v0.43 milestone Nov 29, 2022
@jerop jerop changed the title TEP-0114: Custom Tasks Beta - Move v1alpha1.Run to v1beta1.CustomRun TEP-0114: Custom Tasks Beta - Support v1alpha1.Run and v1beta1.CustomRun Nov 29, 2022
@jerop jerop changed the title TEP-0114: Custom Tasks Beta - Support v1alpha1.Run and v1beta1.CustomRun TEP-0114: Custom Tasks Beta - Support v1beta1.CustomRun Nov 29, 2022
@jerop
Copy link
Member Author

jerop commented Nov 29, 2022

This was completed and released in v0.42.0

@jerop jerop closed this as completed Nov 29, 2022
Repository owner moved this from Todo to Done in Tekton Community Roadmap Nov 29, 2022
Repository owner moved this from In Progress to Done in Pipelines V1 Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Done
Status: Done
Development

No branches or pull requests

6 participants