Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0114: Custom Tasks Beta - References and Specifications #5154

Closed
Tracked by #4313
jerop opened this issue Jul 18, 2022 · 3 comments
Closed
Tracked by #4313

TEP-0114: Custom Tasks Beta - References and Specifications #5154

jerop opened this issue Jul 18, 2022 · 3 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jerop
Copy link
Member

jerop commented Jul 18, 2022

In TEP-0114: Custom Tasks Beta, we proposed migrating Custom Tasks and Runs to beta. This issue tracks this API changes to references and specifications in Custom Tasks and Runs.

Today, embedded specs are in Run.Spec.Spec. In TEP-0114: Custom Tasks Beta, we agreed to align the embedded specs with the rest of the API such that it's CustomRun.Spec.CustomSpec.

# before
apiVersion: tekton.dev/v1alpha1
kind: Run
metadata:
  name: run-with-spec
spec:
  spec:
    apiVersion: example.dev/v1alpha1
    kind: Example
    spec:
      field1: value1
      field2: value2
# after
apiVersion: tekton.dev/v1beta1
kind: CustomRun
metadata:
  name: customrun-with-spec
spec:
  customSpec:
    apiVersion: example.dev/v1beta1
    kind: Example
    spec:
      field1: value1
      field2: value2

Today, references are in Run.Spec.Ref. In TEP-0114: Custom Tasks Beta, we agreed to align the references with the rest of the API such that it's CustomRun.Spec.CustomRef.

# before
apiVersion: tekton.dev/v1alpha1
kind: Run
metadata:
  name: run-with-reference
spec:
  ref:
    apiVersion: example.dev/v1alpha1
    kind: Example
    name: my-example
---
# after
apiVersion: tekton.dev/v1beta1
kind: CustomRun
metadata:
  name: customrun-with-reference
spec:
  customRef:
    apiVersion: example.dev/v1beta1
    kind: Example
    name: my-customtask

Note that the API for TaskRuns and PipelineRuns is:

apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
  name: pipelinerun-with-ref
spec:
  pipelineRef:
    name: my-pipeline
---
apiVersion: tekton.dev/v1beta1
kind: TaskRun
metadata:
  name: taskrun-with-reference
spec:
  taskRef:
    name: my-task
---
apiVersion: tekton.dev/v1beta1
kind: PipelineRun
metadata:
  name: pipelinerun-with-spec
spec:
  pipelineSpec:
    params:
      - name: param1
    tasks:
      - name: my-task
---
apiVersion: tekton.dev/v1beta1
kind: TaskRun
metadata:
  name: taskrun-with-spec
spec:
  taskSpec:
    params:
      - name: param1
    steps:
      - name: my-step
@jerop jerop added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 18, 2022
@lbernick lbernick moved this to Todo in Pipelines V1 Jul 26, 2022
@vsinghai
Copy link

vsinghai commented Aug 1, 2022

/assign

@vsinghai vsinghai removed their assignment Aug 8, 2022
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Aug 31, 2022
Prior to this commit, we proposed migrating
`Custom Tasks` and `Runs` to beta. Today, [embedded specs](https://github.com/tektoncd/pipeline/blob/main/docs/runs.md#2-specifying-the-target-custom-task-by-embedding-its-spec)
are in `Run.Spec.Spec`.

In this commit, we will align the embedded specs
with the rest of the API such that it's
`CustomRun.Spec.CustomSpec`.

Fixes issue [tektoncd#5154](tektoncd#5154)
/cc @jerop
/cc @dibyom

/kind feature
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 1, 2022
Prior to this commit, we proposed migrating
`Custom Tasks` and `Runs` to beta. Today, [embedded specs](https://github.com/tektoncd/pipeline/blob/main/docs/runs.md#2-specifying-the-target-custom-task-by-embedding-its-spec)
are in `Run.Spec.Spec`.

In this commit, we will align the embedded specs
with the rest of the API such that it's
`CustomRun.Spec.CustomSpec`.

Fixes issue [tektoncd#5154](tektoncd#5154)
/cc @jerop
/cc @dibyom

/kind feature
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 1, 2022
Prior to this commit, we proposed migrating
`Custom Tasks` and `Runs` to beta. Today, [embedded specs](https://github.com/tektoncd/pipeline/blob/main/docs/runs.md#2-specifying-the-target-custom-task-by-embedding-its-spec)
are in `Run.Spec.Spec`.

In this commit, we will align the embedded specs
with the rest of the API such that it's
`CustomRun.Spec.CustomSpec`.

Fixes issue [tektoncd#5154](tektoncd#5154)
/cc @jerop
/cc @dibyom

/kind feature
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 2, 2022
Prior to this commit, we proposed migrating
`Custom Tasks` and `Runs` to beta. Today, [embedded specs](https://github.com/tektoncd/pipeline/blob/main/docs/runs.md#2-specifying-the-target-custom-task-by-embedding-its-spec)
are in `Run.Spec.Spec`.

In this commit, we will align the embedded specs
with the rest of the API such that it's
`CustomRun.Spec.CustomSpec`.

Fixes issue [tektoncd#5154](tektoncd#5154)
/cc @jerop
/cc @dibyom

/kind feature
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 2, 2022
Prior to this commit, we proposed migrating
`Custom Tasks` and `Runs` to beta. Today, [embedded specs](https://github.com/tektoncd/pipeline/blob/main/docs/runs.md#2-specifying-the-target-custom-task-by-embedding-its-spec)
are in `Run.Spec.Spec`.

In this commit, we will align the embedded specs
with the rest of the API such that it's
`CustomRun.Spec.CustomSpec`.

Fixes issue [tektoncd#5154](tektoncd#5154)
/cc @jerop
/cc @dibyom

/kind feature
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 2, 2022
Prior to this commit, we proposed migrating
`Custom Tasks` and `Runs` to beta. Today, [embedded specs](https://github.com/tektoncd/pipeline/blob/main/docs/runs.md#2-specifying-the-target-custom-task-by-embedding-its-spec)
are in `Run.Spec.Spec`.

In this commit, we will align the embedded specs
with the rest of the API such that it's
`CustomRun.Spec.CustomSpec`.

Fixes issue [tektoncd#5154](tektoncd#5154)
/cc @jerop
/cc @dibyom

/kind feature
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 2, 2022
Prior to this commit, we proposed migrating
`Custom Tasks` and `Runs` to beta. Today, [embedded specs](https://github.com/tektoncd/pipeline/blob/main/docs/runs.md#2-specifying-the-target-custom-task-by-embedding-its-spec)
are in `Run.Spec.Spec`.

In this commit, we will align the embedded specs
with the rest of the API such that it's
`CustomRun.Spec.CustomSpec`.

Fixes issue [tektoncd#5154](tektoncd#5154)
/cc @jerop
/cc @dibyom

/kind feature
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 2, 2022
Prior to this commit, we proposed migrating
`Custom Tasks` and `Runs` to beta. Today, [embedded specs](https://github.com/tektoncd/pipeline/blob/main/docs/runs.md#2-specifying-the-target-custom-task-by-embedding-its-spec)
are in `Run.Spec.Spec`.

In this commit, we will align the embedded specs
with the rest of the API such that it's
`CustomRun.Spec.CustomSpec`.

Fixes issue [tektoncd#5154](tektoncd#5154)
/cc @jerop
/cc @dibyom

/kind feature
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 2, 2022
Prior to this commit, we proposed migrating
`Custom Tasks` and `Runs` to beta. Today, [embedded specs](https://github.com/tektoncd/pipeline/blob/main/docs/runs.md#2-specifying-the-target-custom-task-by-embedding-its-spec)
are in `Run.Spec.Spec`.

In this commit, we will align the embedded specs
with the rest of the API such that it's
`CustomRun.Spec.CustomSpec`.

Fixes issue [tektoncd#5154](tektoncd#5154)
/cc @jerop
/cc @dibyom

/kind feature
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 6, 2022
Prior to this commit, we proposed migrating
`Custom Tasks` and `Runs` to beta. Today, [embedded specs](https://github.com/tektoncd/pipeline/blob/main/docs/runs.md#2-specifying-the-target-custom-task-by-embedding-its-spec)
are in `Run.Spec.Spec`.

In this commit, we will align the embedded specs
with the rest of the API such that it's
`CustomRun.Spec.CustomSpec`.

Fixes issue [tektoncd#5154](tektoncd#5154)
/cc @jerop
/cc @dibyom

/kind feature
@vsinghai
Copy link

vsinghai commented Sep 6, 2022

/assign

vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 7, 2022
Prior to this commit, we proposed migrating
`Custom Tasks` and `Runs` to beta. Today, [embedded specs](https://github.com/tektoncd/pipeline/blob/main/docs/runs.md#2-specifying-the-target-custom-task-by-embedding-its-spec)
are in `Run.Spec.Spec`.

In this commit, we will align the embedded specs
with the rest of the API such that it's
`CustomRun.Spec.CustomSpec`.

Fixes issue [tektoncd#5154](tektoncd#5154)
/cc @jerop
/cc @dibyom

/kind feature
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 8, 2022
Prior to this commit, we proposed migrating
`Custom Tasks` and `Runs` to beta. Today, [embedded specs](https://github.com/tektoncd/pipeline/blob/main/docs/runs.md#2-specifying-the-target-custom-task-by-embedding-its-spec)
are in `Run.Spec.Spec`.

In this commit, we will align the embedded specs
with the rest of the API such that it's
`CustomRun.Spec.CustomSpec`.

Fixes issue [tektoncd#5154](tektoncd#5154)
/cc @jerop
/cc @dibyom

/kind feature
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 8, 2022
Prior to this commit, we proposed migrating
`Custom Tasks` and `Runs` to beta. Today, [embedded specs](https://github.com/tektoncd/pipeline/blob/main/docs/runs.md#2-specifying-the-target-custom-task-by-embedding-its-spec)
are in `Run.Spec.Spec`.

In this commit, we will align the embedded specs
with the rest of the API such that it's
`CustomRun.Spec.CustomSpec`.

Fixes issue [tektoncd#5154](tektoncd#5154)
/cc @jerop
/cc @dibyom

/kind feature
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 8, 2022
Prior to this commit, we proposed migrating
`Custom Tasks` and `Runs` to beta. Today, [embedded specs](https://github.com/tektoncd/pipeline/blob/main/docs/runs.md#2-specifying-the-target-custom-task-by-embedding-its-spec)
are in `Run.Spec.Spec`.

In this commit, we will align the embedded specs
with the rest of the API such that it's
`CustomRun.Spec.CustomSpec`.

Fixes issue [tektoncd#5154](tektoncd#5154)
/cc @jerop
/cc @dibyom

/kind feature
tekton-robot pushed a commit that referenced this issue Sep 8, 2022
Prior to this commit, we proposed migrating
`Custom Tasks` and `Runs` to beta. Today, [embedded specs](https://github.com/tektoncd/pipeline/blob/main/docs/runs.md#2-specifying-the-target-custom-task-by-embedding-its-spec)
are in `Run.Spec.Spec`.

In this commit, we will align the embedded specs
with the rest of the API such that it's
`CustomRun.Spec.CustomSpec`.

Fixes issue [#5154](#5154)
/cc @jerop
/cc @dibyom

/kind feature
@vsinghai
Copy link

This issue was resolved in #5403 , it can be closed now

vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 12, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 14, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 19, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 20, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 20, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 21, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 21, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
Repository owner moved this from Todo to Done in Pipelines V1 Sep 22, 2022
Repository owner moved this from Todo to Done in Tekton Community Roadmap Sep 22, 2022
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 22, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 22, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 22, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 22, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 26, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
vsinghai pushed a commit to vsinghai/pipeline that referenced this issue Sep 27, 2022
This commit adds a v1beta1 version of the CustomRun CRD,
and support to the webhook.

Fixes issue [tektoncd#5154](tektoncd#5154)
Fixes issue [tektoncd#5153](tektoncd#5153)

/cc @jerop
/kind misc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Done
Status: Done
Development

No branches or pull requests

3 participants