Add Dockerfile for pullrequest nonroot build base image

[zhangtbj]

Changes

As discussed in the issue: #3746

It was planed to support to run pullrequset init image by both root and non-root USER. And in the end, we have an agreement to provide a new Dockerfile on distroless and adding a nonroot 65532 USER.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• [ n ] Includes tests (if functionality changed/added)
• [ n ] Includes docs (if user facing)
• [ n ] Commit messages follow commit message best practices
• [ y ] Release notes block has been filled in or deleted (only if no user facing changes)

/kind misc

Release Notes

For pull requests with a release note:

Add Dockerfile for pullrequset nonroot build base image

[tekton-robot]

Hi @zhangtbj. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ghost]

/ok-to-test
/approve

[ghost]

Hrm, this might be more tricky than it appears because there's no existing nightly images with the git-init-build-base or pullrequest-init-build-base name.

[zhangtbj]

Thanks @sbwsg ,

So is there any workaround to allow build and upload the new images first (maybe manually) before running test?

I think this task (https://github.com/tektoncd/pipeline/blob/master/tekton/build-push-ma-base-image.yaml#L27) was not executed in the PR CI process... :(

[ghost]

OK, I think what we should do is split this PR in two. In the first PR we just add the new images (while still keeping build-base building and in use). Then once that's merged open a new PR which switches git-init and pullrequest-init's base image over to the new ones. We can also remove mention of build-base at that time.

@zhangtbj wdyt?

[zhangtbj]

Sure thing and good idea! @sbwsg ,

I just added the new dockerfile and new build config in this PR and keep using the original build image and config.

Once it is merged, I can provide another PR to use the new generated images.

[afrittoli]

Sure thing and good idea! @sbwsg ,

I just added the new dockerfile and new build config in this PR and keep using the original build image and config.

Once it is merged, I can provide another PR to use the new generated images.

Thank you! 🙏

[ghost]

/test pull-tekton-pipeline-integration-tests

[zhangtbj]

All tests passed now.

Please help to move forward.

Thanks all! :)

[zhangtbj]

/retest

[zhangtbj]

/retest

[zhangtbj]

Interesting, it passed before, but fail at integration-tests, but we didn't change the code of those tests...

[ghost]

Try rebasing on top of main - the main branch of the pipelines repo was changed yesterday. The errors we're seeing here should be fixed by caa661d

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zhangtbj]

Thanks @sbwsg ,

I rebased my PR, the test passed now.

[psschwei]

/lgtm