-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to use new base images for git and pullrequest images #3828
Conversation
/kind misc |
/retest |
Seem Tekton still cannot find the |
Also cc @sbwsg ^^ |
/test pull-tekton-pipeline-build-tests |
/test pull-tekton-pipeline-integration-tests |
6a1624d
to
e482b86
Compare
The images were still not found because the build was broken - fixed in #3834 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Awesome, thanks @zhangtbj and @afrittoli !! /lgtm |
Also thank you @afrittoli and @sbwsg ! :) |
This PR is a follow-up PR after #3810
We already swtiched the
git-init
and pullrequest-init` Dockerfile into the different folder and add these two image build process in the build/publish process.In this PR, we can officially switch to use these two build-base image in the
.ko.yaml
and remove the old Dockerfile or build-base image.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
For pull requests with a release note: