Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use new base images for git and pullrequest images #3828

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

zhangtbj
Copy link
Contributor

This PR is a follow-up PR after #3810

We already swtiched the git-init and pullrequest-init` Dockerfile into the different folder and add these two image build process in the build/publish process.

In this PR, we can officially switch to use these two build-base image in the .ko.yaml and remove the old Dockerfile or build-base image.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [ n ] Includes tests (if functionality changed/added)
  • [ n ] Includes docs (if user facing)
  • [ n ] Commit messages follow commit message best practices
  • [ y ] Release notes block has been filled in or deleted (only if no user facing changes)

For pull requests with a release note:

Add nonroot user in the PullRequest init base image

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 13, 2021
@tekton-robot tekton-robot requested review from afrittoli and a user March 13, 2021 10:51
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 13, 2021
@zhangtbj
Copy link
Contributor Author

/kind misc
/ok-to-test

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Mar 13, 2021
@zhangtbj
Copy link
Contributor Author

/retest

@zhangtbj
Copy link
Contributor Author

Seem Tekton still cannot find the git-init-build-base and pullrequest-init-build-base images in the internal flow.... :(

@zhangtbj
Copy link
Contributor Author

Also cc @sbwsg ^^

@afrittoli
Copy link
Member

/test pull-tekton-pipeline-build-tests

@afrittoli
Copy link
Member

/test pull-tekton-pipeline-integration-tests

@afrittoli
Copy link
Member

The images were still not found because the build was broken - fixed in #3834

Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2021
@ghost
Copy link

ghost commented Mar 16, 2021

Awesome, thanks @zhangtbj and @afrittoli !!

/lgtm

@tekton-robot tekton-robot assigned ghost Mar 16, 2021
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2021
@tekton-robot tekton-robot merged commit 967a654 into tektoncd:main Mar 16, 2021
@zhangtbj
Copy link
Contributor Author

Also thank you @afrittoli and @sbwsg ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants