-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEP-0090: Update PipelineRun Status from Child Refs #5014
Conversation
Prior to this change, the function that ensures that PipelineRun status stays in sync with actual TaskRuns and Runs used a map whose key was a PipelineTask name and value was a ChildReference. In this change, we modify the key to be the TaskRun or Run names. This allows us to handle matrixed scenarios, where one PipelineTask has multiple TaskRuns and Runs - hence multiple ChildReferences.
/test pull-tekton-pipeline-go-coverage |
is it a flake? /test pull-tekton-pipeline-build-tests |
/lgtm |
/retest |
5 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Prior to this change, the function that ensures that PipelineRun
status stays in sync with actual TaskRuns and Runs used a map
whose key was a PipelineTask name and value was a ChildReference.
In this change, we modify the key to be the TaskRun or Run names.
This allows us to handle matrixed scenarios, where one PipelineTask
has multiple TaskRuns and Runs - hence multiple ChildReferences.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes