TEP-0090: Sort ChildReferences in tests
#5020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the `ChildReferences` in tests were sorted by `PipelineTaskName`. With `Matrix` multiple `ChildReferences` could have the same `PipelineTaskName` - this causes the tests to be flakey because the slices are not always sorted the same way. In this change, we sort the slices of `ChildReferences` by the name of the `ChildReferences` - mapping to names of `TaskRuns` or `Runs`. This ensures the slices are always sorted the same way, and removes the flakes.
tekton-robot
added
release-note-none
dibyom
reviewed
Jun 22, 2022
dibyom
approved these changes
Jun 22, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm Good catch! |
|
/test pull-tekton-pipeline-alpha-integration-tests |
5 tasks
jerop
changed the title
ChildReferences in testsChildReferences in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prior to this change, the
ChildReferencesin tests were sortedby
PipelineTaskName. WithMatrixmultipleChildReferencescould have the same
PipelineTaskName- this causes the tests tobe flakey because the slices are not always sorted the same way.
In this change, we sort the slices of
ChildReferencesby the nameof the
ChildReferences- mapping to names ofTaskRunsorRuns.This ensures the slices are always sorted the same way, and removes
the flakes.
Related PR: #5014
/kind flake
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
Release Notes