Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResolvePipelineRunTask to ResolvePipelineTask 🧹 #5029

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

jerop
Copy link
Member

@jerop jerop commented Jun 23, 2022

Changes

In #5025, we renamed ResolvedPipelineRunTask to ResolvedPipelineTask. In this change, we rename the function that creates it to align with the new type name.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Docs included if any changes are user facing
  • [n/a] Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jun 23, 2022
@tekton-robot tekton-robot requested review from abayer and dlorenc June 23, 2022 12:55
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 23, 2022
In tektoncd#5025, we renamed
ResolvedPipelineRunTask to ResolvedPipelineTask. In this change,
we rename the function that creates it to align with the new
type name.
@jerop jerop changed the title ResolvePipelineRunTask to ResolvedPipelineTask 🧹 ResolvePipelineRunTask to ResolvePipelineTask 🧹 Jun 23, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@abayer
Copy link
Contributor

abayer commented Jun 23, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@tekton-robot tekton-robot merged commit 3aab18c into tektoncd:main Jun 23, 2022
@jerop jerop deleted the rprt-migration branch June 23, 2022 18:50
@jerop
Copy link
Member Author

jerop commented Jun 29, 2022

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants