-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add almost-empty v1 package #5055
Conversation
3fc40f1
to
2e1710e
Compare
8628b23
to
aa3f1ac
Compare
/retest |
/retest |
blocked on #5066 |
This commit adds a package for v1 and updates the hack directory to generate code and OpenAPI spec for v1. The v1 package is left as minimal as possible; however, the code does not build and pass tests without at least one generated client. Therefore, a Task type is added with only a Description field, with the rest of the Task spec to be added in a future commit.
/test pull-tekton-pipeline-alpha-integration-tests |
/lgtm |
Looks good in general, though I'm inherently a bit wary of adding a Would like to get thoughts from others from @tektoncd/core-maintainers |
@abayer this is just the code and the package, it is not exported or exposed in any way. This is what we did for |
@lbernick handled that bit nicely - generating /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Changes
This commit adds a package for v1 and updates the hack directory to generate
code and OpenAPI spec for v1. The v1 package is left as minimal as possible;
however, the code does not build and pass tests without at least one generated client.
Therefore, a Task type is added with only a Description field, with the rest of the
Task spec to be added in a future commit.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
(if there are no user facing changes, use release note "NONE")
Release Notes