Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump knative/pkg to latest (20220701) #5066

Closed
wants to merge 1 commit into from
Closed

Bump knative/pkg to latest (20220701) #5066

wants to merge 1 commit into from

Conversation

lbernick
Copy link
Member

@lbernick lbernick commented Jul 1, 2022 •
edited
Loading

Changes

This commit pulls in the latest version of knative and updates k8s
from v0.23.5 to v0.23.8.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • n/a Docs included if any changes are user facing
  • n/a Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

Bumps minimum required version of k8s to 1.22

@lbernick
Bump knative/pkg to latest (20220701)
6e02bf5 
This commit pulls in the latest version of knative and updates k8s
from v0.23.5 to v0.23.8.
@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-none Denotes a PR that doesnt merit a release note. labels Jul 1, 2022
@tekton-robot tekton-robot requested review from jerop and vdemeester July 1, 2022 19:47
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 1, 2022
@lbernick lbernick marked this pull request as ready for review July 1, 2022 19:47
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2022
@tekton-robot tekton-robot requested a review from imjasonh July 1, 2022 19:47
@lbernick
Copy link
Member Author

lbernick commented Jul 1, 2022

/test pull-tekton-pipeline-unit-tests

(cloud event timeout)

@tekton-robot
Copy link
Collaborator

@lbernick: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-unit-tests

(cloud event timeout)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lbernick
Copy link
Member Author

lbernick commented Jul 1, 2022

/test tekton-pipeline-unit-tests

@lbernick lbernick mentioned this pull request Jul 1, 2022
Merged
3 tasks
dibyom
dibyom reviewed Jul 1, 2022
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

vendor/knative.dev/pkg/version/version.go
@@ -33,7 +33,7 @@ const (
// NOTE: If you are changing this line, please also update the minimum kubernetes
// version listed here:
// https://github.com/knative/docs/blob/mkdocs/docs/snippets/prerequisites.md
defaultMinimumVersion = "v1.21.0"
defaultMinimumVersion = "v1.22.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the min k8s version after this change will be 1.22. Can we add a release note?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes, we are actually still on 1.21 for dogfooding

Copy link
Member

@vdemeester vdemeester Jul 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is why #4928 was "on hold".
Do we need absolutely need the version from July 1st or a "released" version (like release-1.5) is ok ? (I know technically it's not really "released" but…) I am asking because we track only released version of all our dependencies except knative/pkg 😅
In any case, we may want to update how we bump knative/pkg (see https://github.com/tektoncd/pipeline/pull/4928/files#diff-ff3402c713d8a504795b7115caa1af088b1bfc583d43adb5d0bc5a83aaa03bc1, it is obsolete).

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Jul 1, 2022
mattmoor
mattmoor approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mattmoor
To complete the pull request process, please ask for approval from dibyom after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lbernick
Copy link
Member Author

lbernick commented Jul 7, 2022

I'd rather not bump the min k8s version and we have #4928 anyway so I'll close this

@lbernick lbernick closed this Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@mattmoor mattmoor mattmoor approved these changes

@jerop jerop Awaiting requested review from jerop

@vdemeester vdemeester Awaiting requested review from vdemeester

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@mattmoor mattmoor

@dibyom dibyom

Labels
kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lbernick @tekton-robot @vdemeester @mattmoor @dibyom