Mark v1beta1 apis as deprecated

[lbernick]

Now that v1 versions of Task, TaskRun, Pipeline, and PipelineRun are available and used as the storage version of these APIs, this commit marks the v1beta1 versions of these APIs as deprecated.

This commit also clarifies that "support" for these APIs during the deprecation period means that they will receive bug fixes but not new features.

/kind documentation
Part of #5541

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• n/a Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

action required: v1beta1 Task, TaskRun, Pipeline, and PipelineRun APIs are deprecated and will be removed. Please migrate to the v1 versions of these APIs following the migration guide at https://github.com/tektoncd/pipeline/blob/main/docs/migrating-v1beta1-to-v1.md.

[Yongxuanzhang]

/lgtm

[QuanZhang-William]

Thanks, Lee! Changes look good to me. I'm curious about what is the impact of marking the v1beta1 crds as deprecated? Does it mean I can no longer kubectl apply a v1beta1 pipelinerun for example?

[jerop]

/test pull-tekton-pipeline-go-coverage

[afrittoli]

Thanks, Lee! Changes look good to me. I'm curious about what is the impact of marking the v1beta1 crds as deprecated? Does it mean I can no longer kubectl apply a v1beta1 pipelinerun for example?

There is no change until the CRD is "removed" (i.e. not served anymore).
It signals users that they should migrate their resources to v1.

[afrittoli]

/hold Just wanted to give @pritidesai an opportunity to review this as she commented about this topic during the last WG.

[afrittoli]

Thank you!
/approve

[pritidesai]

@lbernick and I talked offline, thanks @lbernick for this PR 🙏

Once the PR is updated to include the steps you shared, we can merge this.

Release 0.50 where v1beta1 is deprecated
Release v0.59 where v1beta1 is no longer served, but we still have the client libraries
Release 0.71 we remove the client libraries

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, jerop, pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [afrittoli,jerop,pritidesai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[afrittoli]

/test pull-tekton-pipeline-integration-tests

[lbernick]

@lbernick and I talked offline, thanks @lbernick for this PR 🙏

Once the PR is updated to include the steps you shared, we can merge this.

Release 0.50 where v1beta1 is deprecated
Release v0.59 where v1beta1 is no longer served, but we still have the client libraries
Release 0.71 we remove the client libraries

Done!

[vdemeester]

So this mean we are planning to remove v1beta1 in less than a year (9 month from now), am I right ? This will mean we are removing v1beta1 API "quicker" than we removed v1alpha1 API, which is a bit worrysome 😅 (especially seeing that few of our customers just moved from v1alpha1 to v1beta1). We gave more than a year to migrate from v1alpha1 to v1beta1, but we give less than a year to migrate from v1beta1 to v1 ?

In addition, all our "plumbing" (here in tekton or in tektoncd/plumbing) are still using v1beta1 even. I would assume we would at least have them all migrated to v1 (and have a few cycle of "uses" with them in v1) before marking v1beta1 as deprecated (and we also need to actually exercise a recent version on tektoncd/pipeline ourselves.. our cluster still runs 0.44). A discussion/debate could also take place of the catalogs on the same subject (v1beta1 API still served there).

So.. I am really worried about marking it as deprecated it as early as 0.50 (July release).

/hold

[lbernick]

So this mean we are planning to remove v1beta1 in less than a year (9 month from now), am I right ? This will mean we are removing v1beta1 API "quicker" than we removed v1alpha1 API, which is a bit worrysome 😅 (especially seeing that few of our customers just moved from v1alpha1 to v1beta1). We gave more than a year to migrate from v1alpha1 to v1beta1, but we give less than a year to migrate from v1beta1 to v1 ?

If we want to allow more time to migrate from v1beta1 to v1, we should discuss changing our compatibility policy. If we don't follow our compatibility policy, how will we know when it's acceptable to remove support for these CRDs?

I also just want to note a few things:

• our deprecation table describes the "earliest" date or release of removal, but we still have the option to remove the v1beta1 CRDs later
• v1 CRDs have already been available since v0.43.0
• If you want longer support for v1beta1 CRDs, you can stick with v0.59.0 (which is LTS) for a year rather than upgrading

In addition, all our "plumbing" (here in tekton or in tektoncd/plumbing) are still using v1beta1 even. I would assume we would at least have them all migrated to v1 (and have a few cycle of "uses" with them in v1) before marking v1beta1 as deprecated (and we also need to actually exercise a recent version on tektoncd/pipeline ourselves.. our cluster still runs 0.44). A discussion/debate could also take place of the catalogs on the same subject (v1beta1 API still served there).

That's a good point; it could definitely make sense to have some usage of v1 in plumbing before we mark v1beta1 as deprecated. We can also upgrade the 4 tasks in tektoncd-catalog but I don't think we should wait for the tasks in tektoncd/catalog to upgrade. (However, I'd hope our integration tests and upgrade tests are good enough to give us sufficient confidence in the v1 api!)

[lbernick]

@vdemeester I've opened #6923 for discussion on the beta CRD support window.

[afrittoli]

@vdemeester @lbernick shall we try and get this merged for v0.50?

[vdemeester]

@afrittoli I would say yes 🙃
@lbernick I approved #6923 👼🏼

[lbernick]

/hold cancel
I've updated this PR based on the discussions resolved in #6923

[vdemeester]

@lbernick needs a rebase 🙏🏼

[lbernick]

done! just needs lgtm

[vdemeester]

/lgtm