-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Increase support window for v1beta1 CRDs to 1 year #6923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lbernick
I thought about this a bit more, and I wonder if perhaps we should leave the current policy for changes to a beta API as it is, and add an extra clause specific about the full removal of an API?
I think 9 months is quite a long time already and I'm afraid that if we make it even longer it will inhibit development when we get to a v2alpha1
release, because switching to v2beta1
would already mean 1 year stability commitment, which would result again in us stagnating on the unstable API versions, customers adopting them even if they are unstable, and then the cycle repeating.
Perhaps instead we could leave the 9 months as they are, and possibly reduce them in future, and add a clause specific for v1beta1
removal.
That would work for me too (aka both approach LGTM 🙃 ) |
@afrittoli just to make sure I understand what you're suggesting:
Or are you suggesting the v1beta1 api is a special case? FWIW I share your concerns about increasing the support window and having users come to rely on beta apis. |
This commit updates the support policy for v1beta1 CRDs to 1 year, to give users more time to migrate off of the v1beta1 API. v1beta1 is considered a special case because there were no stable APIs available when it was created. To avoid users becoming dependent on future unstable APIs and inhibiting development, the existing policy of 9 months will apply to future beta CRDs.
@afrittoli @vdemeester I've updated the proposal to apply to v1beta1 only based on your feedback, PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @lbernick !
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-tekton-pipeline-go-coverage-df |
@afrittoli: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold just waiting until the end of the day |
/lgtm |
/hold cancel |
This commit updates the support policy for v1beta1 CRDs to 1 year, to give users more time to migrate off of the v1beta1 API.
v1beta1 is considered a special case because there were no stable APIs available when it was created. To avoid users becoming dependent on future unstable APIs and inhibiting development, the existing policy of 9 months will apply to future beta CRDs.
/kind documentation
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes