HTTP/2 Parser implementation (#309). #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This is just an intermediate review - a lot of things unfinished and not fixed since #1338 . Also I didn't dive too deeply into the code though.
1. Changes in HPACK decoder to copy only Huffman-decoded and dynamically indexed headers; 2. Appropriate changes in HPACK-decoder/parser unit-tests.
Corrections as a result of HPACK decoder/encoder/parser unit-tests debugging.
krizhanovsky
requested changes
Nov 21, 2019
krizhanovsky
requested changes
Nov 22, 2019
|
While HTTP/2 usage is still less than HTTP/1.1, it actually means that site owners don't deploy HTTP/2 and just stay on current (old) configurations. Meantime, it seems the most modern web clients do support HTTP/2, so
|
TfwStrs often go in arrays, and there is a 1-byte alignment gap between TfwStr neighbours. `eolen` is always [0,2], 14-bits are enough for hpack index.
# Conflicts: # tempesta_fw/http_parser.c # tempesta_fw/http_sess.c # tempesta_fw/t/unit/test_hpack.c # tempesta_fw/t/unit/test_http_sticky.c
krizhanovsky
previously requested changes
Dec 7, 2019
There was a problem hiding this comment.
More notes to make the HTTP/2 parser faster, required for #1207.
…ve duplication conflicts
…renct additions of CRLF
Don't switch fsm state on processing frame header, update the fsm state only after the full frame is processed. Otherwise the fsm is triggered twice and fsm closes the connection when a new fragment of frame is expected.
Fix request h2 -> http1.1 conversion
Parse name, colon, LWS, value and RWS of HTTP/1.1-response headers into separate chunks to facilitate the name/value splitting and colon/OWS eviction during HTTP/1.1=>HTTP/2 response transformation.
A few review comment fixes for http2 parser
…ion-h2-cache HTTP/2 implementation: HTTP/2-cache (#309).
vankoven
dismissed
krizhanovsky’s stale review
@krizhanovsky is out for conference and the PR should be merged before the conference
vankoven
approved these changes
Mar 5, 2020
This was referenced Mar 5, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.