Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/2 Parser implementation (#309). #1368

Merged
merged 69 commits into from
Mar 5, 2020
Merged

HTTP/2 Parser implementation (#309). #1368

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
71d7b7a
HTTP/2 Parser implementation (#309).
aleksostapenko Oct 16, 2019
dc71702
HTTP/2 Parser implementation (#309):
aleksostapenko Oct 30, 2019
b5658be
HTTP/2 Parser implementation: some comments added for HPACK functiona…
aleksostapenko Oct 30, 2019
9a57b1f
HTTP/2 Parser implementation: numerous corrections and cleanups (#309).
aleksostapenko Oct 31, 2019
8f9a906
HTTP/2 Parser implementation: removal of outdated (already done) 'TOD…
aleksostapenko Oct 31, 2019
fb7c80f
HTTP/2 Parser implementation (#309):
aleksostapenko Nov 4, 2019
e50d74d
HTTP/2 Parser implementation: redesign of HTTP/1.1=>HTTP/2 transforma…
aleksostapenko Nov 12, 2019
c935484
HTTP/2 Parser implementation: corrections according to debugging resu…
aleksostapenko Nov 21, 2019
f2e01bd
HTTP/2 Parser implementation: corrections in internal response genera…
aleksostapenko Nov 22, 2019
c692adb
bump copyrights
vankoven Dec 4, 2019
dae477a
Divide TfwStr flags and HPACK index members
vankoven Dec 4, 2019
8849e87
Fix compile-time issues with 'stack frame non-standard' warnings
vankoven Dec 4, 2019
ae7ce40
Update code comments
vankoven Dec 4, 2019
e9bf486
Update Linux kernel patch
vankoven Dec 4, 2019
e8b1f87
Remove unneeded ss_skb_data() function
vankoven Dec 4, 2019
266581d
Minor style fixups
vankoven Dec 4, 2019
45c9eba
Generate HPACK header on compiletime
vankoven Dec 4, 2019
7b1cce0
Merge branch 'master' into ik-1369-merge-master
vankoven Dec 6, 2019
fd48c6e
Resolve merge issues
vankoven Dec 17, 2019
80d2d4a
Fail test if parsed string was composed incorrectly, don't crash
vankoven Dec 17, 2019
b1e6a11
port changes from avb-1202 to http2
vankoven Dec 17, 2019
0620349
Set-cookie was added in two branches with different processing, resol…
vankoven Dec 17, 2019
d4c682d
Add HPACK generator and generated file
krizhanovsky Dec 17, 2019
c67a387
Fix some small comments
krizhanovsky Dec 17, 2019
a5519f8
Hpack state machine table in no more generated, product of generated …
vankoven Dec 17, 2019
5c77db5
port method override detection feature to HTTP2
vankoven Dec 17, 2019
a7de0eb
Fix pointer assignment
vankoven Dec 17, 2019
db602d2
replace bug_on with warn_on
vankoven Dec 29, 2019
54fab94
Port parsing accept header according to rfc to http2
vankoven Dec 29, 2019
82b7376
Port encoding headers to Huffman encoding
vankoven Dec 29, 2019
66752e4
Remove unneeded template file
vankoven Dec 29, 2019
2d2480b
Add tests for huffman encoding
vankoven Dec 30, 2019
4d7eb66
Add unit tests for hufman encoding
vankoven Dec 30, 2019
d647d63
Fix code review comments
vankoven Dec 30, 2019
1d15fab
Merge pull request #1373 from tempesta-tech/ik-1368-additions
vankoven Dec 30, 2019
d306c1b
Fix request h2 -> http1.1 conversion
vankoven Dec 18, 2019
0d6e7c6
Fix code review comments
vankoven Dec 30, 2019
1b15a89
Update saver pointer ht after tfw_http_msg_grow_hdr_tbl() calls
vankoven Dec 31, 2019
9a4c20c
Fix setting local headers
vankoven Dec 31, 2019
b4e2719
fix header calculations
vankoven Jan 3, 2020
ebe2b83
Fix h2 fsm transitions
vankoven Jan 5, 2020
06d75c2
Don't close h2 request body until it's fully received
vankoven Jan 9, 2020
bee3246
Fix moving request body on h2->h1 transformation
vankoven Jan 9, 2020
a31df74
Fix crash on debug builds
vankoven Jan 9, 2020
04c0fc9
Add todo: split message into multiple frames
vankoven Jan 9, 2020
f9c1644
Add todo: h2 protocol requires lower case headers, not mixed case
vankoven Jan 9, 2020
2ad4c3f
h2: content-length is extra header, don't block messages if it's absent
vankoven Jan 10, 2020
2b69ff4
h2: close connection if remote sends too huge frames
vankoven Jan 11, 2020
e6b400d
Fix null pointer dereference on modifications on h1 headers and incor…
vankoven Jan 11, 2020
e257d63
h2: check settings before apply them. Reject if limits defined in RFC…
vankoven Jan 11, 2020
ee0dced
Add issue number for TODOs
vankoven Jan 11, 2020
6849d75
Update macro documentations
vankoven Jan 11, 2020
3cb5ec0
h2: Add several TODO comments
vankoven Jan 11, 2020
f91139f
h2: fix too early fsm update for CONTINUATION frames
vankoven Jan 11, 2020
e7bd235
h2: Improve check for mandatory pseudo headers presense
vankoven Jan 11, 2020
c114bed
Fix code review comments
vankoven Jan 21, 2020
f010557
Merge pull request #1374 from tempesta-tech/ik-fix-req-2-to-1-transform
vankoven Jan 21, 2020
c721aaa
HTTP/2 Parser implementation: HTTP/2-cache (#309).
aleksostapenko Feb 18, 2020
4dec0e8
HTTP/2: changes in processing of headers strings (#309).
aleksostapenko Feb 27, 2020
2d7bb75
HTTP/2: fix duplicate headers processing during response forwarding (…
aleksostapenko Feb 29, 2020
b5e71ac
HTTP/2: add header name tracking into the headers' compare procedure …
aleksostapenko Mar 1, 2020
4f0cdd1
HTTP/2: corrections according review comments (#309).
aleksostapenko Mar 2, 2020
bb502ae
h2 parser: reduce number of compare operators during headers parsing
vankoven Mar 1, 2020
2585ef9
If listening for http/1.1 mode print performance warning
vankoven Mar 1, 2020
a841f0b
Bump copyrights
vankoven Mar 3, 2020
5b7ecb5
Merge pull request #1385 from tempesta-tech/ik-h2-parser-updates
vankoven Mar 3, 2020
4f43032
HTTP/2: evict redundant space during response status-line creation fr…
aleksostapenko Mar 4, 2020
6164968
HTTP/2: corrections according additional review comments (#309).
aleksostapenko Mar 4, 2020
7b4fc72
Merge pull request #1383 from tempesta-tech/ao-309-parser-transformat…
aleksostapenko Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions tempesta_fw/cache.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1153,6 +1153,7 @@ tfw_cache_copy_resp(TfwCacheEntry *ce, TfwHttpResp *resp, size_t tot_len)
long n, etag_off = 0;
char *p;
TdbVRec *trec = &ce->trec, *etag_trec = NULL;
TfwStr *s_line = &resp->h_tbl->tbl[TFW_HTTP_STATUS_LINE];
TDB *db = node_db();
TfwStr *field, *h, *end1, *end2, empty = {};
int r, i;
Expand All @@ -1176,7 +1177,7 @@ tfw_cache_copy_resp(TfwCacheEntry *ce, TfwHttpResp *resp, size_t tot_len)
ce->method = req->method;

ce->status = TDB_OFF(db->hdr, p);
if ((n = tfw_cache_strcpy_eol(&p, &trec, &resp->s_line, &tot_len, 1)) < 0) {
if ((n = tfw_cache_strcpy_eol(&p, &trec, s_line, &tot_len, 1)) < 0) {
T_ERR("Cache: cannot copy HTTP status line\n");
return -ENOMEM;
}
Expand All @@ -1185,7 +1186,7 @@ tfw_cache_copy_resp(TfwCacheEntry *ce, TfwHttpResp *resp, size_t tot_len)
ce->hdrs = TDB_OFF(db->hdr, p);
ce->hdr_len = 0;
ce->hdr_num = resp->h_tbl->off;
FOR_EACH_HDR_FIELD(field, end1, resp) {
FOR_EACH_HDR_FIELD_FROM(field, end1, resp, TFW_HTTP_HDR_REGULAR) {
bool hdr_304 = false;

/* Skip hop-by-hop headers. */
Expand Down Expand Up @@ -1282,7 +1283,7 @@ __cache_entry_size(TfwHttpResp *resp)
size += req->h_tbl->tbl[TFW_HTTP_HDR_HOST].len;

/* Add all the headers size */
FOR_EACH_HDR_FIELD(hdr, hdr_end, resp) {
FOR_EACH_HDR_FIELD_FROM(hdr, hdr_end, resp, TFW_HTTP_HDR_REGULAR) {
/* Skip hop-by-hop headers. */
if (!(hdr->flags & TFW_STR_HBH_HDR))
h = hdr;
Expand All @@ -1304,7 +1305,7 @@ __cache_entry_size(TfwHttpResp *resp)
}

/* Add status line length + CRLF */
size += resp->s_line.len + SLEN(S_CRLF);
size += resp->h_tbl->tbl[TFW_HTTP_STATUS_LINE].len + SLEN(S_CRLF);

/* Add body size accounting CRLF after the last chunk */
size += resp->body.len;
Expand Down Expand Up @@ -1532,6 +1533,7 @@ tfw_cache_build_resp(TfwHttpReq *req, TfwCacheEntry *ce)
{
int h;
char *p;
TfwStr *s_line;
TfwHttpResp *resp;
TdbVRec *trec = &ce->trec;
TDB *db = node_db();
Expand Down Expand Up @@ -1577,12 +1579,13 @@ tfw_cache_build_resp(TfwHttpReq *req, TfwCacheEntry *ce)
goto err;
}

s_line = &resp->h_tbl->tbl[TFW_HTTP_STATUS_LINE];
if (tfw_cache_write_field(db, &trec, resp, &it, &p,
ce->status_len, &resp->s_line))
ce->status_len, s_line))
goto err;

resp->h_tbl->off = ce->hdr_num;
for (h = 0; h < ce->hdr_num; ++h) {
for (h = TFW_HTTP_HDR_REGULAR; h < ce->hdr_num; ++h) {
TFW_STR_INIT(resp->h_tbl->tbl + h);
if (tfw_cache_build_resp_hdr(db, resp, resp->h_tbl->tbl + h,
&trec, &it, &p))
Expand Down
Loading