-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add query a pool endpoint through poolCoin or reserveAcc #390
Add query a pool endpoint through poolCoin or reserveAcc #390
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #390 +/- ##
===========================================
+ Coverage 82.52% 82.72% +0.20%
===========================================
Files 20 20
Lines 2283 2287 +4
===========================================
+ Hits 1884 1892 +8
+ Misses 226 224 -2
+ Partials 173 171 -2
Continue to review full report at Codecov.
|
…erveacc # Conflicts: # x/liquidity/keeper/liquidity_pool.go # x/liquidity/types/utils.go
95aa107
to
767164a
Compare
…add-query-pool-through-poolcoin-reserveacc # Conflicts: # x/liquidity/client/cli/query.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of functionality, I tested both CLI and REST interfaces and they work well. Everything looks good to me other than the two dots used in query.proto
file and the TODO comment you left in utils.go
Update: I wasn't aware that this is draft PR. In case you need another review when it is ready to review, I'll review it again.
Description
closes: #345
pool-coin-denom
flag to cliliquidityd query liquidity pool
reserve-acc
flag to cliliquidityd query liquidity pool
/tendermint/liquidity/v1beta1/pools/pool_coin_denom/{pool_coin_denom}
endpoint to API/tendermint/liquidity/v1beta1/pools/reserve_acc/{reserve_acc}
endpoint to APIhttps://app.swaggerhub.com/apis-docs/bharvest/cosmos-sdk_liquidity_module_rest_and_g_rpc_gateway_docs/2.2.2
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes