Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query a pool endpoint through poolCoin or reserveAcc #390

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Jun 3, 2021

Description

closes: #345

  • Add pool-coin-denom flag to cli liquidityd query liquidity pool
  • Add reserve-acc flag to cli liquidityd query liquidity pool
  • Add /tendermint/liquidity/v1beta1/pools/pool_coin_denom/{pool_coin_denom} endpoint to API
  • Add /tendermint/liquidity/v1beta1/pools/reserve_acc/{reserve_acc} endpoint to API
  • Add test cases
  • Update documentation

https://app.swaggerhub.com/apis-docs/bharvest/cosmos-sdk_liquidity_module_rest_and_g_rpc_gateway_docs/2.2.2


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #390 (c67d0b1) into develop (e47b7af) will increase coverage by 0.20%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #390      +/-   ##
===========================================
+ Coverage    82.52%   82.72%   +0.20%     
===========================================
  Files           20       20              
  Lines         2283     2287       +4     
===========================================
+ Hits          1884     1892       +8     
+ Misses         226      224       -2     
+ Partials       173      171       -2     
Impacted Files Coverage Δ
x/liquidity/types/utils.go 92.30% <75.00%> (-7.70%) ⬇️
x/liquidity/keeper/liquidity_pool.go 81.18% <100.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8ab2f4...c67d0b1. Read the comment docs.

@jaybxyz jaybxyz added the enhancement New feature or request label Jun 4, 2021
@dongsam dongsam force-pushed the dongsam/add-query-pool-through-poolcoin-reserveacc branch from 95aa107 to 767164a Compare June 7, 2021 15:31
Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of functionality, I tested both CLI and REST interfaces and they work well. Everything looks good to me other than the two dots used in query.proto file and the TODO comment you left in utils.go

Update: I wasn't aware that this is draft PR. In case you need another review when it is ready to review, I'll review it again.

@dongsam dongsam requested a review from jaybxyz June 9, 2021 07:33
@dongsam dongsam marked this pull request as ready for review June 9, 2021 07:35
@dongsam dongsam merged commit 874e382 into tendermint:develop Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding query a pool endpoint through poolCoin or reserveAcc
4 participants