Fix empty request check #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comparing pointers would not have any effects, so compare by values
15 tasks
Codecov Report
@@ Coverage Diff @@
## develop #391 +/- ##
========================================
Coverage 82.94% 82.94%
========================================
Files 20 20
Lines 2240 2240
========================================
Hits 1858 1858
Misses 209 209
Partials 173 173 Continue to review full report at Codecov.
|
dongsam
added a commit
to b-harvest/liquidity
that referenced
this pull request
Jun 7, 2021
dongsam
added a commit
that referenced
this pull request
Jun 9, 2021
* WIP Add pool query endpoints * Add endpoint functionality for query pool by pool coin denom * fix for #391 * change endpoint of pool query by pool_coin_denom * add endpoint for query pool by reserve_acc * CLI denomination and reserve acc queries added * Add flags for query pool by pool-coin-denom or reserve-acc * Add testcase, docs for new endpoint * Fix typo and resolve lint issue Co-authored-by: lukerhoads <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
comparing pointers would not have any effects, so compare by values
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes