Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revitalize Test Prefetcher #16364

Open
nhuang-tt opened this issue Dec 30, 2024 · 0 comments
Open

Revitalize Test Prefetcher #16364

nhuang-tt opened this issue Dec 30, 2024 · 0 comments
Assignees
@nhuang-tt

Comments

@nhuang-tt
Copy link
Member

  1. Remove compile args code from test prefetcher to use the FD Topology static/dependent configs graph
  • Some functions in FD topology will need to generalized to support more kernel types (i.e., test kernel)
  1. Use DispatchSettings (from Improved address management and configuration for FD #16339) as the default arguments
  2. Remove the use of globals
@nhuang-tt nhuang-tt self-assigned this Dec 30, 2024
nhuang-tt added a commit that referenced this issue Dec 30, 2024
@nhuang-tt
#16364: generalize FDKernel generator function
3b95a4b
nhuang-tt added a commit that referenced this issue Dec 30, 2024
@nhuang-tt
#16364: generalize FDKernel generator function
1bd1a77
@nhuang-tt nhuang-tt mentioned this issue Dec 30, 2024
Draft
6 tasks
nhuang-tt added a commit that referenced this issue Dec 30, 2024
@nhuang-tt
#16364: put FDKernels into a namespace
32c53ff
nhuang-tt added a commit that referenced this issue Jan 4, 2025
@nhuang-tt
#16364: update params
0173a4c
nhuang-tt added a commit that referenced this issue Jan 4, 2025
@nhuang-tt
#16364: use dispatch_constants
e53a967
nhuang-tt added a commit that referenced this issue Jan 4, 2025
@nhuang-tt
#16364: seperate compile args
55ea23a
nhuang-tt added a commit that referenced this issue Jan 7, 2025
@nhuang-tt
#16364: use the proper semaphores
f042c35
nhuang-tt added a commit that referenced this issue Jan 7, 2025
@nhuang-tt
#16364: remove unused compile args
9dceb6d
nhuang-tt added a commit that referenced this issue Jan 7, 2025
@nhuang-tt
#16364: use the correct semaphores
0a9e456 
remove overlapping semaphores which were enforced
by assertions
nhuang-tt added a commit that referenced this issue Jan 8, 2025
@nhuang-tt
#16364: move core config code out
8a12219
nhuang-tt added a commit that referenced this issue Jan 17, 2025
@nhuang-tt
#16364: place dispatch kernels into namespace
c7dcdf3
nhuang-tt added a commit that referenced this issue Jan 17, 2025
@nhuang-tt
#16364: uplift node_id_to_kernel
4021f86 
the topology functions need to accept the topology
graph as a parameter. using a global makes it hard
to use this code for tests

- removed the usage of raw pointers
- uplifted node_id_to_kernel to FDTopologyManager
@nhuang-tt nhuang-tt mentioned this issue Jan 17, 2025
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nhuang-tt nhuang-tt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nhuang-tt