Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check NoC sanitize for virtual coords #16539

Closed
tt-dma opened this issue Jan 8, 2025 · 1 comment
Closed

Check NoC sanitize for virtual coords #16539

tt-dma opened this issue Jan 8, 2025 · 1 comment
Assignees
@tt-dma

Comments

@tt-dma
Copy link
Contributor

tt-dma commented Jan 8, 2025

Per Paul, on N300 NoC sanitization appears to be off after virtual coords introduced. Can unicast to 26,y and 27,y when workers should be 18..25,y. Need to check if the bounds here need fixing.
@tt-dma tt-dma self-assigned this Jan 8, 2025
tt-dma added a commit that referenced this issue Jan 23, 2025
@tt-dma
#16539: Watcher noc sanitize virtual coord bugfix
8e5e5ae
@tt-dma tt-dma mentioned this issue Jan 23, 2025
Merged
6 tasks
tt-dma added a commit that referenced this issue Jan 24, 2025
@tt-dma
#16539: Watcher noc sanitize virtual coord bugfix
cd05c58
tt-dma added a commit that referenced this issue Jan 24, 2025
@tt-dma
#16539: Watcher noc sanitize virtual coord bugfix
8a59830
@tt-dma
Copy link
Contributor Author

tt-dma commented Jan 24, 2025

Fixed in #17061

@tt-dma tt-dma closed this as completed Jan 24, 2025
patrickroberts pushed a commit that referenced this issue Jan 25, 2025
@tt-dma @patrickroberts
#16539: Watcher noc sanitize virtual coord bugfix
d50819f
TT-billteng pushed a commit that referenced this issue Jan 27, 2025
@tt-dma @TT-billteng
#16539: Watcher noc sanitize virtual coord bugfix
5c55d9b
williamlyTT pushed a commit that referenced this issue Jan 30, 2025
@tt-dma @williamlyTT
#16539: Watcher noc sanitize virtual coord bugfix
321d672
yieldthought pushed a commit that referenced this issue Jan 31, 2025
@tt-dma @yieldthought
#16539: Watcher noc sanitize virtual coord bugfix
1b2c3ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tt-dma tt-dma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tt-dma