Collection of small watcher fixes #17061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tt-dma
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-asaigal,
ubcheema,
davorchap and
cfjchu
as code owners
pgkeller
approved these changes
Jan 24, 2025
| // For ethernet core, need to have smaller buffer at a different address | ||
| if (is_eth_core) { | ||
| l1_buffer_size = 1024; | ||
| l1_buffer_addr = 200 * 1024; |
There was a problem hiding this comment.
can we grab this from the hal? unreserved base of coord type
tt-dma
force-pushed
the
dma/16716_sanitize_eth_cores_fix
branch
from
8e5e5ae to
cd05c58
Compare
This was referenced Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of watcher bugfixes:
Fix local L1 santization on ethernet: #16716
Fix mentions of physical coords in watcher/dprint: #16474
Fix noc sanitization for virtual coords: #16539
Checklist