Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extends the util by a find by name function #867

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Conversation

FritzHoing
Copy link
Contributor

@FritzHoing FritzHoing commented Jan 9, 2025

According to the new SHOGun-API endpoint, this util introduces a new fetch function.

Copy link
Member

@dnlkoch dnlkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add an unit test for the newly added method?

@FritzHoing
Copy link
Contributor Author

Unit tests are added now 👍

@FritzHoing FritzHoing requested a review from dnlkoch January 13, 2025 07:54
@FritzHoing FritzHoing merged commit ff91112 into main Jan 16, 2025
1 check passed
Copy link

🎉 This PR is included in version 10.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants