Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extend the api with a application name endpoint #966

Merged
merged 2 commits into from
Jan 16, 2025
Merged

feat: extend the api with a application name endpoint #966

merged 2 commits into from
Jan 16, 2025

Conversation

FritzHoing
Copy link
Contributor

Description

This MR extends the API by a new applicationName endpoint.

Related issues or pull requests

terrestris/shogun-util#867

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Tests
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@FritzHoing FritzHoing mentioned this pull request Jan 9, 2025
Merged
LukasLohoff
LukasLohoff approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@LukasLohoff LukasLohoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I think naming the endpoint either /byName or /findByName would make it easier to understand what it is doing.

@FritzHoing FritzHoing merged commit de669ef into main Jan 16, 2025
4 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 16, 2025
@semantic-release-bot
chore(release): 21.5.0 [skip ci]
c89b740 
# [21.5.0](v21.4.0...v21.5.0) (2025-01-16)

### Features

* extend the api with a application name endpoint ([#966](#966)) ([de669ef](de669ef))
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 21.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnlkoch dnlkoch dnlkoch approved these changes

@LukasLohoff LukasLohoff LukasLohoff approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FritzHoing @dnlkoch @LukasLohoff