-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Release/t25.imp #2339
Draft
Camwyn
wants to merge
147
commits into
master
Choose a base branch
from
release/T25.imp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Test Release/t25.imp #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`current_user_can( 'read', $post_id )` 'read' does not use a post ID. changed to `current_user_can( 'read_post', $post_id )`
…tria-569 & tectria-570.
Fixed issue with tribe_asset.
…elp_header_hidden [Tectria-572] Help Hub - H1 hidden
…preadsheet Help Hub FF Fixes for spreadsheet
…reate false positives due to the transients not clearing.
…reate false positives due to the transients not clearing.
…frame_styles [Tectria-570][Tectria-569] Help Hub Iframe restructuring
…ated_notice Fix warning about deprecated ability
Eliminated unnecessary blank lines in the `remove_dismissed_notices` method to improve code readability. No functionality was affected by this change.
… we're ziping with pup
…o_helphub_ff merging Imp into Help Hub FF
…ith direct instantiations of `Tribe__PUE__Notices`. Additionally, updated tests to align with the new approach and removed unnecessary setup and teardown methods.
…lication Creating tests for Tribe__PUE__Notices class.
…sients Help Hub - Transient issue when installing new plugin
Help Hub FF CR changes.
Help Hub FF into Imp
Refactored `monitor_active_plugins` to handle transient updates more efficiently by dynamically detecting and adding missing plugins. Added a comprehensive integration test to validate correct plugin monitoring and transient behavior, ensuring robustness and reliability.
…sient-new-plugin-issue [TEC-5332] Help Hub transient newly installed plugin issue
tec-bot
reviewed
Jan 9, 2025
} | ||
} | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[phpcs] reported by reviewdog 🐶PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose
Function closing brace must go on the next line following the body; found 1 blank lines before brace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanity check - hold
See also:
the-events-calendar/the-events-calendar#4873
and
the-events-calendar/event-tickets#3475