Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add foreman_kubevirt to config #334

Merged
merged 1 commit into from
May 7, 2019
Merged

Add foreman_kubevirt to config #334

merged 1 commit into from
May 7, 2019

Conversation

masayag
Copy link
Contributor

@masayag masayag commented Mar 18, 2019

No description provided.

@masayag masayag force-pushed the add_foreman_kubevirt branch from 823ff04 to ac5fd5d Compare May 2, 2019 05:44
@masayag
Copy link
Contributor Author

masayag commented May 5, 2019

The PR depends on theforeman/puppet-foreman#730

@masayag masayag changed the title [WIP] Add foreman_kubevirt to config Add foreman_kubevirt to config May 6, 2019
ekohl
ekohl approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restarted the tests now that the puppet-foreman PR is merged. Tests should be green then.

@evgeni evgeni merged commit 89508de into theforeman:develop May 7, 2019
tbrisker pushed a commit that referenced this pull request May 22, 2019
@masayag @tbrisker
Add kubevirt to config (#334)
f1ab67b 
(cherry picked from commit 89508de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni approved these changes

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@masayag @evgeni @ekohl @theforeman-bot