Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding foreman_kubevirt Plugin #730

Merged
merged 1 commit into from
May 6, 2019

Conversation

masayag
Copy link
Contributor

@masayag masayag commented May 1, 2019

No description provided.

@masayag
Copy link
Contributor Author

masayag commented May 1, 2019

I guess that this one will fail until theforeman/foreman-packaging#3647 is merged

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are more like unit tests, not acceptance tests so that doesn't have to block. I do think there was a failure in master already so that doesn't have to block.

manifests/plugin/foreman_kubevirt.pp Outdated Show resolved Hide resolved
manifests/plugin/foreman_kubevirt.pp Outdated Show resolved Hide resolved
manifests/plugin/foreman_kubevirt.pp Outdated Show resolved Hide resolved
@masayag
Copy link
Contributor Author

masayag commented May 6, 2019

@ekohl Is there anything else needed for this PR ?

@ekohl ekohl merged commit 9806590 into theforeman:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants