-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby 2.7 testing to installer jobs #5
Conversation
theforeman.org/pipelines/release/source/foreman-installer.groovy
Outdated
Show resolved
Hide resolved
bc72bc3
to
ecb4095
Compare
How does this matrix look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why you no longer use PUPPET_VERSION
? AFAIK this is still needed to actually be effective due to https://github.com/theforeman/foreman-installer/blob/8310aa688aefd6a339fa7589834b89d79845c151/Gemfile#L5
ecb4095
to
7ae92ca
Compare
Simple forgetting that there is an implied environment variable created that the code itself expects. |
7ae92ca
to
57b85c4
Compare
Please keep in mind I am not intending to add Puppet 7 support here. I had added Ruby 2.7 support and was informed that I should also do so via pairing it with Puppet 7. I want to test and ensure that both Kafo and the Installer's Ruby code runs under 2.7 (as it would on an RPM install) not testing Puppet's runtime ruby. |
@@ -11,11 +11,33 @@ pipeline { | |||
axes { | |||
axis { | |||
name 'ruby' | |||
values '2.4', '2.5', '2.6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we drop 2.4, then IMHO it should also be reflected in the gemspec. Also a PR to drop Puppet 5 support would be the correct thing to do.
57b85c4
to
9dd4848
Compare
I'll keep Puppet 5 around. This uses Reference on excludes -- https://www.jenkins.io/doc/book/pipeline/syntax/#matrix-excludes |
No description provided.