Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 2.7 testing to installer jobs #5

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Feb 19, 2021

No description provided.

@ehelms ehelms force-pushed the add-ruby-2.7-installer branch 2 times, most recently from bc72bc3 to ecb4095 Compare March 5, 2021 20:22
@ehelms
Copy link
Member Author

ehelms commented Mar 5, 2021

How does this matrix look?

@ehelms ehelms requested a review from ekohl March 8, 2021 13:17
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why you no longer use PUPPET_VERSION? AFAIK this is still needed to actually be effective due to https://github.com/theforeman/foreman-installer/blob/8310aa688aefd6a339fa7589834b89d79845c151/Gemfile#L5

@ehelms ehelms force-pushed the add-ruby-2.7-installer branch from ecb4095 to 7ae92ca Compare March 8, 2021 16:03
@ehelms
Copy link
Member Author

ehelms commented Mar 8, 2021

Can you explain why you no longer use PUPPET_VERSION? AFAIK this is still needed to actually be effective due to https://github.com/theforeman/foreman-installer/blob/8310aa688aefd6a339fa7589834b89d79845c151/Gemfile#L5

Simple forgetting that there is an implied environment variable created that the code itself expects.

@ehelms ehelms force-pushed the add-ruby-2.7-installer branch from 7ae92ca to 57b85c4 Compare March 8, 2021 16:30
@ehelms ehelms requested a review from ekohl March 8, 2021 17:03
@ehelms
Copy link
Member Author

ehelms commented Mar 8, 2021

Please keep in mind I am not intending to add Puppet 7 support here. I had added Ruby 2.7 support and was informed that I should also do so via pairing it with Puppet 7. I want to test and ensure that both Kafo and the Installer's Ruby code runs under 2.7 (as it would on an RPM install) not testing Puppet's runtime ruby.

@@ -11,11 +11,33 @@ pipeline {
axes {
axis {
name 'ruby'
values '2.4', '2.5', '2.6'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we drop 2.4, then IMHO it should also be reflected in the gemspec. Also a PR to drop Puppet 5 support would be the correct thing to do.

@ehelms ehelms force-pushed the add-ruby-2.7-installer branch from 57b85c4 to 9dd4848 Compare March 24, 2021 14:20
@ehelms
Copy link
Member Author

ehelms commented Mar 24, 2021

I'll keep Puppet 5 around. This uses notValues in the excludes which to my understanding should mean, even though using excludes that what you see in the section represents the valid combination of values.

Reference on excludes -- https://www.jenkins.io/doc/book/pipeline/syntax/#matrix-excludes

@ehelms ehelms merged commit c94c33f into theforeman:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants