Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Puppet 7 #329

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Support Puppet 7 #329

merged 1 commit into from
Mar 24, 2021

Conversation

mattock
Copy link
Contributor

@mattock mattock commented Mar 24, 2021

Without the metadata.json change kafo_configure fails with

Puppet 7.5.0 does not meet requirements for theforeman-kafo_configure (>= 4.5.0 < 7.0.0)
Cannot continue due to incompatible version of Puppet. Use --skip-puppet-version-check to disable this check.

when trying to run a Kafo-based installer. Gemfile changes may be needed elsewhere, not sure.

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@ehelms
Copy link
Member

ehelms commented Mar 24, 2021

[test kafo]

@ehelms
Copy link
Member

ehelms commented Mar 24, 2021

I have proposed changes to our CI jobs to test on Puppet 7 -- theforeman/jenkins-jobs#5

@ehelms
Copy link
Member

ehelms commented Mar 24, 2021

[test kafo]

1 similar comment
@ehelms
Copy link
Member

ehelms commented Mar 24, 2021

[test kafo]

@ehelms ehelms merged commit 333ade6 into theforeman:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants