Fixes #30078 - add parameter to accept a hostgroup config hash

[apatelKmd]

No description provided.

[ekohl]

Would you mind squashing the commits? Also use Fixes #30078 - <message>. Looks like now the check doesn't detect it.

[apatelKmd]

I want to know how can I use the parameter with multiple hashes. For e.g, I want to add the same parameters as described in the spec test. Can you help with it?

foreman-installer --foreman-plugin-default-hostgroup-hostgroups ???

[ekohl]

kafo is the engine behind exposing parameters. In particular https://github.com/theforeman/kafo#hash-arguments is relevant. However, I don't know how it would deal with a hash inside a hash. I think there's even a bug in that --param=key:value doesn't work and needs to be --param key:value. Perhaps --param key:nested_key:value works. Otherwise that might be a possible RFE.

Another solution is to put it in custom-hiera.yaml. This is not really what we want (answers for exposed classes should be preferred), but if it's the only way, it has to be that way. Then you would use (from the top of my head):

foreman::plugin::default_hostgroup::hostgroups:
  key:
    nested_key: value

[apatelKmd]

Thanks @ekohl for clarifying the use of the parameter. Use of custom-hiera.yaml will do. What version of the foreman-installer will include the update? If we know the future plan we can prepare our installer arguments accordingly.

[ekohl]

At this moment we're in the Foreman 2.2 development cycle. If it's merged in the next few weeks, that'll be the version to contain it.

[apatelKmd]

@ekohl AFAIK, the changes are complete. Please let me know if you want me to make an update?

[apatelKmd]

@ekohl I have incorporated your suggestions followed by squash and rebase.

[ekohl]

Overall 👍, just a last small whitespace note.

[ekohl]

Right now the tests are still running, but other than that this can be merged.

[apatelKmd]

Lint test failed, I pushed an update to resolve the issue.

[ekohl]

Thanks!