Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #35985 - Rely on theforeman/puppet to do integration #440

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jan 24, 2023

The integration is moved into theforeman/puppet so this is no longer needed.

Depends on theforeman/puppet-puppet#862.

@ekohl
Copy link
Member Author

ekohl commented Jan 27, 2023

puppet-systemd 4 came out and broke puppet-redis. This isn't a problem in production, since there we're still on 3 but does break our test suite.

@ekohl
Copy link
Member Author

ekohl commented Jan 27, 2023

I've opened voxpupuli/puppet-systemd#313 which is probably the easiest fix in the short term.

@ekohl ekohl force-pushed the 35985-rely-on-puppet-module branch from 04b49f7 to 5943a15 Compare January 27, 2023 12:48
The integration is moved into theforeman/puppet so this is no longer
needed.
@ekohl ekohl force-pushed the 35985-rely-on-puppet-module branch from 5943a15 to a28eb02 Compare January 27, 2023 13:40
Copy link
Member

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know there is an order, or group that have to go in together. This one looks good as the stand-alone change, only merge when the rest are ready.

@ekohl ekohl merged commit 12bbe7a into theforeman:master Feb 20, 2023
@ekohl ekohl deleted the 35985-rely-on-puppet-module branch February 20, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants